Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp899925pxj; Fri, 4 Jun 2021 00:37:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdoIrSxtTlu00rz/tu3dzkMP9KsfSr5nDghYOVarUGZvxovq2wL4p3gZyhy/+4Ats3PDG/ X-Received: by 2002:a05:6402:26ce:: with SMTP id x14mr3389234edd.104.1622792239795; Fri, 04 Jun 2021 00:37:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622792239; cv=none; d=google.com; s=arc-20160816; b=nJjoBiCiOI9ZAKXtRJQE4xUg3UiQay6b0lo6jGggJmOsjRtW0TNgTjgKPT0EME0Rlk i1uJ6m7b+tTGKHHPHTVOrZ/zU5flgT+yR35nBp0OvaUbH2dHu/ab4UkicrMOAPWA/xxE 06FGI/R54WYouHFV1wsu+SAyqKxw4RvskgCKWi0RLR7q6/ZkMsBP+hJ4XLZHSNHImskq x2wIzwLTEThWSs22rr6jaXOB/I8UDRj2/5BjiQUYGlvxNe8o/ULZ5f5BXb4UbFirMclR cdcjhtvjGNyD9BnJ/9YMEqLHqSv4QYJbx8VgHGrU/tZLyAFSSDlwy8rAZu9X0UprPSrb ++zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=+Vmu+0ZtyeTntxhyb20XZ4zHkNem1Heojo//cpglhTs=; b=YLRW4qgDGJqBSG1tFa/JP3iQSJgNvskHuXq8m6eMpFX/rfBzMMxGWmTZqJt0wooG3a Z171xUmNbuHZoqJfcvklmxtfe7WLH64Z/Et3aJXgdqjwSb0/qsJ1itMDtUGXqQZF3nd0 FE/r4qpL9A9JCo0gZqc3l3Tldq1tKK3TLXDgXw2leBZ75Ic+JnfEqMZj/tmIRgP/W8AN iAVNYUCfY9UhC7QuYliQnlpn2NJXsaoN91Im+XW/F5t5e64KTihR9L1745Dftne355aq 6389nKuZOIpJJmH3vL5/8c6OTmRsNFA3Hk0E59cU+z+ZXw3xNTnGZbwxE2TXCI8EN26P V5OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cn25si3927228edb.530.2021.06.04.00.36.57; Fri, 04 Jun 2021 00:37:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbhFDHhG (ORCPT + 99 others); Fri, 4 Jun 2021 03:37:06 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3425 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbhFDHhG (ORCPT ); Fri, 4 Jun 2021 03:37:06 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FxDxH1TpYz6v5Q; Fri, 4 Jun 2021 15:32:19 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 15:35:18 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 15:35:18 +0800 From: Guangbin Huang To: , , , , CC: , , , Subject: [PATCH net-next 5/6] net: hdlc_x25: fix the code issue about "if..else.." Date: Fri, 4 Jun 2021 15:32:11 +0800 Message-ID: <1622791932-49876-6-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1622791932-49876-1-git-send-email-huangguangbin2@huawei.com> References: <1622791932-49876-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li According to the chackpatch.pl, else should follow close brace '}'. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/wan/hdlc_x25.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c index 4e771f7..bd4fad3 100644 --- a/drivers/net/wan/hdlc_x25.c +++ b/drivers/net/wan/hdlc_x25.c @@ -310,8 +310,7 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr) new_settings.t1 = 3; new_settings.t2 = 1; new_settings.n2 = 10; - } - else { + } else { if (copy_from_user(&new_settings, x25_s, size)) return -EFAULT; -- 2.8.1