Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp905356pxj; Fri, 4 Jun 2021 00:47:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNim+Fxx4RnrDN9JnArBLP3+rDJXSIPo3bGy5Mcj6ecUxGWI4zLn5TFaTIZFW51OW3TfTK X-Received: by 2002:a17:906:4111:: with SMTP id j17mr2963314ejk.488.1622792873216; Fri, 04 Jun 2021 00:47:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622792873; cv=none; d=google.com; s=arc-20160816; b=sy2s4KndIbA+8t2Mj1XoV8besnCn51Csrv6eKLrhufxZeuryGdhSVB8lpDNa/lAlKY AS91VRqE/WgsgUiWeXkoG8pHYZr4oDXRiD7uUz+jaiAUlkhrslX107hAhYJVnC+ijof7 wCQdWeE8PKEtbmw3csI7Y0cLLl5DmavQ0gDEub/fH2uUAKSgRo9s/sfuhkrDenYDC/Gw eT44mWgDXZoMW7PzAdcLjijNdArqUAzQ+Y4mYA1iBsY0pXYoOeMs6ZxjQwkXmYzilcTm X8UUK37D4EzTqQEr0vNnMEYGnu2B8QcbZSHlZKa5PyzaFaOR0mHgIvvtnH69/+i2UNP9 eXmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=un0F/vMB1as+8PlF4+ud9qIkBU19hc8DoD6YAjyWcy0=; b=rUsn8xhboMy/9IKwJDAi2OW+4xqgFiNS5lNFjAlCS6L8keoresqNlhE1aOH3iQZYhN Iu4wzA0V9yY2uh3UGDc5xaPT30L3DQeah45LmDcFZkqg/ROwcp/V+bEH02zH46p4z2Lq fjhvzSbD2/1kszZRohdjE4J/+ysRck0+xhxvPNP0kqBbv+s56cNc6q1OL1S7LqYnMRDe YJxe9h1+ZYpbffnIxvpWT+Kcxn4RQlI0LGzhAuQX1eP/oFC/ha9MCd9B29B2BfFrve2z HfqW0nIlijpFWgjjhyB+9TsoBvqR7GiM5w0cg1FVhi/CI0ZpaksGotz9CG0/12fPBGak mI+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Fwupc6a/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w22si4610071edi.259.2021.06.04.00.47.29; Fri, 04 Jun 2021 00:47:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Fwupc6a/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbhFDHsL (ORCPT + 99 others); Fri, 4 Jun 2021 03:48:11 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:41756 "EHLO mail-lf1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbhFDHsL (ORCPT ); Fri, 4 Jun 2021 03:48:11 -0400 Received: by mail-lf1-f46.google.com with SMTP id v8so12677449lft.8 for ; Fri, 04 Jun 2021 00:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=un0F/vMB1as+8PlF4+ud9qIkBU19hc8DoD6YAjyWcy0=; b=Fwupc6a/DGTOQ8oMq0bGNwyIcz7ZET0LwWu6M/eKzjcQXl1Jh6Ett+hbBZcTy64rGi JVxlS3+hi9Jlbd3dnE6RN7lGqJt0+G07bnsojvdx2HwX7ptHC/7zXWcOpDKAciOBZn/p 9DXWZNP6ErZaz4liObuPSLBYGQFDPDCKHgKbLD3TQZjGKIf2diSYSQb/Kyq7nZLI+pz+ l1JqDaK3Cbi80PkIFW+D07pUBTk/bVr4QlZ9ezzO5QVJUldMpTI/aAokfqZV99gaVA65 Rq4G9yjmP7vkyb8UKVZM9kd/NtTXwcZiNMH1uSppbVELQbBq49/hAdStrNWxemYxDGtj jfTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=un0F/vMB1as+8PlF4+ud9qIkBU19hc8DoD6YAjyWcy0=; b=YqAsxwfLiqckoClS6Qdja/BvvUt81is+laJFqcS/AkukUAnGNLmACgOMpjnBHi6UQk Y31EVJ98RymN2QaA7j/AVmr/yMovQjITyURL+F0pWcyzkB/ohWCBetmOqmJRVQ7R+e7x zOMs0/kUsVg9DheAiTdGuoTrVwxGRcLpglXFd72e0jIEIdLoRZlEHJfaDgX+o32LGwdC SNcjgaotM6OhtsHMO2uZNWZ945NKY9fxQutQa8EsjFIeWmUpPOUQh1z+IVY4DTMiGnxE dLsXNdWQoMs9QCmgpY5PGMk1/FNLJAYo2RUax3wVkIpLjkNgjLQqnMUb+UDg2mW/mUmn 88Iw== X-Gm-Message-State: AOAM533ugRE4IAXX6oTXfJ9qK8jQ8Vd1zAwdexhIXqOvjBS40BWNX7B7 tSu/KeuakbWNljfVawrM8cj221Kx9BkI/sErQbjgwQ== X-Received: by 2002:a05:6512:2105:: with SMTP id q5mr1858743lfr.649.1622792711079; Fri, 04 Jun 2021 00:45:11 -0700 (PDT) MIME-Version: 1.0 References: <20210604014055.4060521-1-keescook@chromium.org> In-Reply-To: <20210604014055.4060521-1-keescook@chromium.org> From: Linus Walleij Date: Fri, 4 Jun 2021 09:44:59 +0200 Message-ID: Subject: Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends To: Kees Cook Cc: Daniel Vetter , Emma Anholt , David Airlie , linux-kernel , "open list:DRM PANEL DRIVERS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 4, 2021 at 3:41 AM Kees Cook wrote: > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when > pl111 is modular. Update the Kconfig to reflect the need. > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG") Yeah that doesn't work, thanks for fixing this! > Signed-off-by: Kees Cook > - depends on VEXPRESS_CONFIG > + depends on ARM || ARM64 || COMPILE_TEST > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n That's the right solution, Reviewed-by: Linus Walleij Yours, Linus Walleij