Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Jun 2021 10:39:43 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: Fix debugfs_read_file_str()
Message-ID: <YLnmz7dOek/aTJAn@hirez.programming.kicks-ass.net>
References: <20210527091105.258457-1-dietmar.eggemann@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210527091105.258457-1-dietmar.eggemann@arm.com>
Precedence: bulk

On Thu, May 27, 2021 at 11:11:05AM +0200, Dietmar Eggemann wrote:
> Read the entire size of the buffer, including the trailing new line
> character.
> Discovered while reading the sched domain names of CPU0:
> 
> before:
> 
> cat /sys/kernel/debug/sched/domains/cpu0/domain*/name
> SMTMCDIE
> 
> after:
> 
> cat /sys/kernel/debug/sched/domains/cpu0/domain*/name
> SMT
> MC
> DIE
> 
> Fixes: 9af0440ec86eb ("debugfs: Implement debugfs_create_str()")
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

Urgh.. so much for last minute changes :/

Greg, AFAICT that commit has since landed in Linus, will you take care
of this?

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>