Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp935784pxj; Fri, 4 Jun 2021 01:45:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwE556FkUAwQY65O0M2foU1LuPUoYOEU5onvSo/yKMmyf+oCFN0rf+E+5RyMj6PyXOYy0VM X-Received: by 2002:a17:907:2136:: with SMTP id qo22mr3183570ejb.40.1622796355716; Fri, 04 Jun 2021 01:45:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622796355; cv=none; d=google.com; s=arc-20160816; b=lRkXN00+tn/3Kx8iLKPUe3RgFjgvzJWY+wmifhSUAL9eshWgYidgE4Jiy+nnB5nQ/x JypQTVzLiOPGRoC48hl9vB901H9fgUdCg04YEZlTezE9BLIhKpbIi4GEB4VOC61l0iUY OE31gyoxGqen6Kk/bcctADmVzVf/llA6sAMlrsszUVoSodclZjEDnGADZyFIUKbNtaeP Qh6hWhQsP6Vc5c2ZEDf6584pJwJT3hL6p5cTXfeN6Q1KjXDJ0zrSt57QhBFW9rWVXWVN ZwGxpayiV8QYd8Z5CZy4m9uv6bYAst+jd19Ww46XnI95U4EGQBe5kBiRXTEoJ3XfAMt5 N+vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/ME7R43Oz5qvoJp6XLHw2SaFOz7wVkh76dKe7RVe8Kk=; b=lDYMm/VV5aRUTwRweB2Epy8dxgoHI5izFRanRAELUoc2SnaA0Cex7qluT3bLfSqcJk zXaMWhStskbys36S9rimouHTVx2ijWHukXPztxEnAp7jBpdlm3Oa7EndbkTd+po56FaL Xohz01BypAQl9sAMxKSATvsxSwkuMrGTGRzvBGBtDosh5Swuc5m3CKDs2lh2POazkhi2 P7Uu7biK1aKa1uaGBCEMdTJ7bqE3Qz7hAfX8/mUrzFrCCLLWIFYrphCv5JqIf5wopQIo 9Jb5noYMopDKqmSD1HJhuRltgtzeIJA0oRCmDVPYrUrvhnJjAtCPmilha2qg/oOu/eI/ i11g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jGd6DqWk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v7si5148972edj.541.2021.06.04.01.45.31; Fri, 04 Jun 2021 01:45:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jGd6DqWk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhFDIpO (ORCPT + 99 others); Fri, 4 Jun 2021 04:45:14 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:38422 "EHLO mail-wr1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbhFDIpN (ORCPT ); Fri, 4 Jun 2021 04:45:13 -0400 Received: by mail-wr1-f44.google.com with SMTP id j14so8461065wrq.5 for ; Fri, 04 Jun 2021 01:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/ME7R43Oz5qvoJp6XLHw2SaFOz7wVkh76dKe7RVe8Kk=; b=jGd6DqWkaAWksWxsZRh6WUWPRk3a2bZZ0wx3zTLf6N7R2y/VxNEItQtvFvN186iMzz nmywnenM+OUbGDr3Z8q10FpW0MbxFJIWqr0pp95rjYzFWyxHaHwbOKwstf5X+fKUowFT AYJwv3pkPMEHFf+veSdWRZQucvLGB5e1nQspXD2rX1C/ZBJCtLbMXEe0CS01R0uWEdq1 DjikTt0KB948De2dwDvddMb/92zDi8WT8yDJi9fOYKKnMzuJ4uk3yYPTWgf/KdBROAwV Qkc+4KqoVQ4RVvlfy3syQt7OouZYgdSziPIYpt39MyoqZA/IUDJWOYoPPs0FgHpM0Xex Tl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/ME7R43Oz5qvoJp6XLHw2SaFOz7wVkh76dKe7RVe8Kk=; b=THWjF3kLqki7mStNaCRdQxjoZPRG/lEuTFKRdSUZNhrV/kkIs5ek+dWvcu1iAyQpwn cilTV2Z8NTviDxgPx9DkQGdNJqf/ML4vgfFTqF9bYWj00v0YWTgAfIJC260qpUYa9F9m ugEmATFNtlMgC5sPfzbrEMTg7ctsnJGStLIpNa2bw4nEiAI2pRTUx90X28wfdAnrZTKZ 2BN2LsD1zbLpnivMSSeHKTPsRPv/O3NE7dL6KuxEkNq0ppf7aIuQiYzHH2FNDc5kD0RD j7QKHXHSbnBa5CFDwYbX70ktOT07jGln5MR7iQpousxhWFHKiAvRc8LDfQxGquHfaWp5 rhTQ== X-Gm-Message-State: AOAM533DTKT3+qXgwsbZb1xQn2yHmp552/yYfcHMR5MRbe0hQdiUPBeI Bxliyp+d8dB4+Xkwv9sXD4f2qA== X-Received: by 2002:adf:ee52:: with SMTP id w18mr2648602wro.37.1622796146844; Fri, 04 Jun 2021 01:42:26 -0700 (PDT) Received: from iliass-mbp (ppp-2-87-186-192.home.otenet.gr. [2.87.186.192]) by smtp.gmail.com with ESMTPSA id l16sm8290772wmj.47.2021.06.04.01.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 01:42:26 -0700 (PDT) Date: Fri, 4 Jun 2021 11:42:17 +0300 From: Ilias Apalodimas To: Yunsheng Lin Cc: Matteo Croce , netdev@vger.kernel.org, linux-mm@kvack.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Subject: Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling Message-ID: References: <20210521161527.34607-1-mcroce@linux.microsoft.com> <20210521161527.34607-4-mcroce@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] > > + /* Driver set this to memory recycling info. Reset it on recycle. > > + * This will *not* work for NIC using a split-page memory model. > > + * The page will be returned to the pool here regardless of the > > + * 'flipped' fragment being in use or not. > > + */ > > I am not sure I understand how does the last part of comment related > to the code below, as there is no driver using split-page memory model > will reach here because those driver will not call skb_mark_for_recycle(), > right? > Yes the comment is there to prohibit people (mlx5 only actually) to add the recycling bit on their driver. Because if they do it will *probably* work but they might get random corrupted packets which will be hard to debug. > > + page->pp = NULL; > > + page_pool_put_full_page(pp, virt_to_head_page(data), false); > > + > > + return true; > > +} > > +EXPORT_SYMBOL(page_pool_return_skb_page); >