Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp951978pxj; Fri, 4 Jun 2021 02:17:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoaEOd1PFD+0CV4N2Ttq7xPWKwvxroIhzUxoDCbmE0NFN2KRlU8GsjsqXh5n8GBIG0J0HK X-Received: by 2002:a17:906:3c56:: with SMTP id i22mr3339882ejg.369.1622798250741; Fri, 04 Jun 2021 02:17:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622798250; cv=none; d=google.com; s=arc-20160816; b=qyBqAXq1VcKDzNfr6bmheuaLZHvYXHlHGhyRQrNkpF0QfmCHoSPlo/Z1cFOQb6cdLa 7avcApG1Qm3P3ZiMlPOvjq3fR9jJ0PzOhY8UxTm3W5I7WWLl7XXEFmEEw67RKu7K/V/f AExdeNbDnuzFSjSpRHLcWBRk1VekvrC7869BBuC7bZWuPhjbRgauAZenfUtRPj15xMf5 R5lcmKK0Xr3U7w2wPO9eEc+sAOnqXcp35GxaJ0hSppRZmQZR+NwTtpV4AcEsEpQQ8A2M NRuNVx5yGeV05WgkLO2WWlmxZ4eNEiqM4lFZ0kQz2LbZxPza0LlfUDSOiIvzjDFRzPC+ chQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=0iAE1eXsi7Ags0kCh2NQ+Xw4BO7hibZ8156NIUiiC9Y=; b=GGi+LuKuZ4Nq93Vev9AUqssM8kOsI+b+tnwGvDre7jD3cfCzPK0LtHBWt0pHrzwnLQ gcv6tDG6d4ea4nrBnK2CY8FFLMvx3j925rqtx2oK0uBkVGT81k6z4yiZEWx0UFPf4cdt f0CTQQXhi+IcjfUQrK1M1Oovgk090gSBTrOyWwmSDv0YcGIQ4UfGlnVSRh0lhGv2QDV0 sfMFyvZ8noX73nqeElxCjf8YXyNZ0j+N5QSL95gH05+ikgldbXz0wU5fCAzozSGhlkOQ FGhK7I93EGW+i1jCKtDndD+q9hsKpTUvc5NuzzZDx02u7SCgdD2O2Soe2Xo6/fr3CoTg m4Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=jXU7Ugry; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si3951847edr.251.2021.06.04.02.17.07; Fri, 04 Jun 2021 02:17:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=jXU7Ugry; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbhFDJSC (ORCPT + 99 others); Fri, 4 Jun 2021 05:18:02 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:53059 "EHLO mail-wm1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbhFDJSC (ORCPT ); Fri, 4 Jun 2021 05:18:02 -0400 Received: by mail-wm1-f50.google.com with SMTP id f17so4944914wmf.2 for ; Fri, 04 Jun 2021 02:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=0iAE1eXsi7Ags0kCh2NQ+Xw4BO7hibZ8156NIUiiC9Y=; b=jXU7UgrylnRUSGeCbfj1NxKE31gatksb608K/jN+nlg9LYwbeaeTZoAwcju45NWPNL Dll+M8tntKovKq1yobA2cANrzCfOGfHj9DvwCTVs43XpI723jBuZkYsrqBolUZlPSvA4 1LH0u8TTFb6ZSwQUY/IReeDHz11/L/zgeWokY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=0iAE1eXsi7Ags0kCh2NQ+Xw4BO7hibZ8156NIUiiC9Y=; b=rv0ZDPQQ2HoLFKuzcwGvXY1J3DIkuav3UzyubW6807c3dD2LacB7fLJ+7X2vqdmPKu 2HKjYkxt0o5/CqCURBMjXQEIwVo/O7nJNSjd6BCxZDqJcdktgQph1bl22wMSOq+odxgX Rtp50ANQVAxFLc86tVFew1OOjYJPu2cyvkfgqs8b/zhNGmw5Jam8vel5hQQ/Ers1tbt6 1eHDHApZxxhW9rTmq0EYw95nAmerobILtJFqhUZ3/vRgLFQYr4lKDgGW0vZwWioaP1Sa 69WqNV91ZgDmTRy3RJCJDSFjmIZAyOMBLBvOcg3lLbU/iNCfJ9BtBCmCYhCnC1JRpNmz todg== X-Gm-Message-State: AOAM532VnQ+tql2/uCE/wzm/5OxB3ao/g5c+Q6AXSXemnqiaqwu234s8 hIz/LlJtVL4gmf7dqf3kPQnJymUHL4d8DA== X-Received: by 2002:a7b:c450:: with SMTP id l16mr2640565wmi.117.1622798115481; Fri, 04 Jun 2021 02:15:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id o17sm5681880wrp.47.2021.06.04.02.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 02:15:15 -0700 (PDT) Date: Fri, 4 Jun 2021 11:15:13 +0200 From: Daniel Vetter To: Linus Walleij Cc: Kees Cook , Daniel Vetter , Emma Anholt , David Airlie , linux-kernel , "open list:DRM PANEL DRIVERS" Subject: Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends Message-ID: Mail-Followup-To: Linus Walleij , Kees Cook , Emma Anholt , David Airlie , linux-kernel , "open list:DRM PANEL DRIVERS" References: <20210604014055.4060521-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote: > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook wrote: > > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when > > pl111 is modular. Update the Kconfig to reflect the need. > > > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG") > > Yeah that doesn't work, thanks for fixing this! > > > Signed-off-by: Kees Cook > > > - depends on VEXPRESS_CONFIG > > + depends on ARM || ARM64 || COMPILE_TEST > > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n > > That's the right solution, > Reviewed-by: Linus Walleij Since I screwed up already, care to also push this to drm-misc-next? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch