Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp958530pxj; Fri, 4 Jun 2021 02:29:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq72NiywBzAhxqJsewJMCa2YKi3lFpfcWAYx62e0Y1aexzJDDhExm8pNvk6h+PuZvvJatP X-Received: by 2002:a17:906:2da1:: with SMTP id g1mr3264227eji.47.1622798998768; Fri, 04 Jun 2021 02:29:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622798998; cv=none; d=google.com; s=arc-20160816; b=QeJiigfR85DnPqnRPsY1yR6G4lCzJ9LorAytQ6P/poZ19YbEbWD6QG9aUEPJatDols CwD3CY7TiLolpaFbaqUBo51IsfdrBviyxiaLr1QMHWq/LJQJnQVAoW2ACMF8TYQQVt8M vPzIfr9vsavNjMByfHYcoE3RfiuFufQ/aZ9+UQb7CLUuoUst4oAwVuI90WMHi+r50VJG ko5R0HPUd/wUCJZLwh7OBjCZhWHF9kL5d5lVjoovjeRbuj5oqn43Rb/R1rtZrzlbTCyj IMnmBsaHPdPuhIHvUFDn7zc0wCjoM7MNCbs1SjkfFcra8ToH9UjghSJ8GaOY9HPWS5Kw 3rSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jL6ap00KaFBke4iG3IweIqWMAJLw20Di0Yq3H8NV+0c=; b=Aq5hEA6YgvxhbDWviQRKrYxHnPnQOksuzy7PZ4CxH+kUjbZn82QPeyLrmyV/Gzni6k DvX8JwGzHMuov+Sb031r7Ix4Oko854TfIo5Qv9cHPUJ5IDzcdpLxlPbtbPc4Yz4/chJ2 vMdWSOxsJrNwykHfEzkI7Hv9bS5pDpRf8L+wj1WFmGp7prxHt50R6NCdCMpCekTXRmjQ /tnbxefFMQArJ7K3Kyc/3DLFBp6IJn9o/sbAxWMJpQVBRa0X7BR2sLEBJ5cnf4P04o8g cRlWxFoaZIofHrmzw/7oEUQjJT3fNPebmEwj9bB4UbzvDb002AsWO+8a8GWOgJalRs58 Owow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si4660105ejn.74.2021.06.04.02.29.34; Fri, 04 Jun 2021 02:29:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbhFDJaF (ORCPT + 99 others); Fri, 4 Jun 2021 05:30:05 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:4357 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbhFDJaF (ORCPT ); Fri, 4 Jun 2021 05:30:05 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FxHQj3dcnz68bF; Fri, 4 Jun 2021 17:24:29 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 17:28:15 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 17:28:15 +0800 From: Yang Yingliang To: , CC: , , Subject: [PATCH net-next] net: mscc: ocelot: check return value after calling platform_get_resource() Date: Fri, 4 Jun 2021 17:32:34 +0800 Message-ID: <20210604093234.3408625-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang --- drivers/net/dsa/ocelot/seville_vsc9953.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c index 84f93a874d50..b514e2d05b6f 100644 --- a/drivers/net/dsa/ocelot/seville_vsc9953.c +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c @@ -1206,6 +1206,10 @@ static int seville_probe(struct platform_device *pdev) felix->info = &seville_info_vsc9953; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + err = -EINVAL; + dev_err(&pdev->dev, "Invalid resource\n"); + } felix->switch_base = res->start; ds = kzalloc(sizeof(struct dsa_switch), GFP_KERNEL); -- 2.25.1