Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp988387pxj; Fri, 4 Jun 2021 03:23:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW80AwcOt48HALkotpm5sa8uwTsUzxmdpfSgM8tbRaAL4P8uVU6IF9bPHI9r9RYyPbUnRB X-Received: by 2002:a17:906:b308:: with SMTP id n8mr3475815ejz.93.1622802237128; Fri, 04 Jun 2021 03:23:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622802237; cv=none; d=google.com; s=arc-20160816; b=kWfLBqpbGAaxs9/BXsZxnb5J/Y9VCygbzkaRr9lKA2MpbiulQ6rZ3kNE/23ohNoBs1 Tk1WXJmssDMXSnG+1I1mQstoW0KnS+VhRAQ+h+99YRDPQUg0zYijoh0NfQJ/GayL2Zvs oEpywkwclYpuO+g68cc/CmgGY/QfCf4byVJClPH8/iglO3koovkkfypPCU5D+kraiAva rVszkhgvDSxWFR0rgmOMHqPbLZ40whS3V33Fcvqg8waxqHui8rkClIf5APys5IVOgHDA POY9IsfeFNBmzIc3GQLn1aBQEfXV55xKobxYdGfNq+jK4PA5OBgIzpO+ghfTwrDccorH uQ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=/ozZ/cRVqDA5WZ1WaOVqlLurD1jW/ILhD1bOWsRUbwg=; b=BmrGNh+xHws2OZnmua/+xIMSqA2MirBHFI8xgw5z5bU4bkMRdWOA5xbRQSs+Qp5Cli XPRLwd7HNdIz4/11l78qh1qIdF0RA3M2OttWxpaZUBb9NwRo6OKPCifGXrpOU9XwC1XK krO3/oJzi2cxY/pGtqPfbtG+6zaYWVXgryWNQ6modSNmBi0qpMfjRc5Wl03qhX1b+/7y zucm2vf841b7KuEDpSvwFMJMbQBYsLKcA7/h+cfF2ukR2bVkIfm0+cx8Z7s/JJU2mN2m lXOCc2u6WUiW8Itbe59Cbs+2lnag2q5hHkh3//tfxJBs/eFeXSN6ZRqeJ8T6I3u5z3Di 7CiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si4843167edc.193.2021.06.04.03.23.32; Fri, 04 Jun 2021 03:23:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbhFDKXH (ORCPT + 99 others); Fri, 4 Jun 2021 06:23:07 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:53906 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbhFDKXH (ORCPT ); Fri, 4 Jun 2021 06:23:07 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UbFb0BY_1622802077; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UbFb0BY_1622802077) by smtp.aliyun-inc.com(127.0.0.1); Fri, 04 Jun 2021 18:21:18 +0800 From: Yang Li To: jdmason@kudzu.us Cc: dave.jiang@intel.com, allenbh@gmail.com, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Date: Fri, 4 Jun 2021 18:20:50 +0800 Message-Id: <1622802051-43464-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the function IS_ALIGNED() returns false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/ntb/test/ntb_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 89df135..c20b375 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer) return -ENOMEM; } if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) { + ret = -ENOMEM; dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n"); goto err_free_inbuf; } -- 1.8.3.1