Subject: Re: __alloc_pages() failures reported due to fragmentation
From: Arjan van de Ven <arjan@infradead.org>
To: Larry Woodman <lwoodman@redhat.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <454B3282.3010308@redhat.com>
References: <454B3282.3010308@redhat.com>
Content-Type: text/plain
Organization: Intel International BV
Date: Fri, 03 Nov 2006 13:21:54 +0100
Message-Id: <1162556514.14530.163.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1150
Lines: 33


> --- linux-2.6.18.noarch/net/core/sock.c.orig
> +++ linux-2.6.18.noarch/net/core/sock.c
> @@ -1154,7 +1154,7 @@ static struct sk_buff *sock_alloc_send_p
>  			goto failure;
>  
>  		if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) {
> -			skb = alloc_skb(header_len, sk->sk_allocation);
> +			skb = alloc_skb(header_len, gfp_mask);
>  			if (skb) {
>  				int npages;
>  				int i;

Hi,

this is not actually right though... sk_allocation is very possible to
have a restricting mask compared to the one passed in (say "no highmem"
or even GFP_DMA) and you now discard this... probably better would be to
calculate a set of "transient" flags that you then or into the
sk_allocation mask at this time...

Greetings,
   Arjan van de Ven

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/