Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210603063430.6613-1-ihuguet@redhat.com> <20210603074419.2930-1-hdanton@sina.com>
 <CACT4oudUd2YuV=GFhz1asvwX8h_mGtqzjZygBD26Tj98cxfCpw@mail.gmail.com> <20210604031450.3039-1-hdanton@sina.com>
In-Reply-To: <20210604031450.3039-1-hdanton@sina.com>
From:   =?UTF-8?B?w43DsWlnbyBIdWd1ZXQ=?= <ihuguet@redhat.com>
Date:   Fri, 4 Jun 2021 13:19:23 +0200
Message-ID: <CACT4ouccprqnx_Dt4dk8SvFrdW9OmnyRxC9KAM7q6n7925umHg@mail.gmail.com>
Subject: Re: [PATCH 1/2] net:cxgb3: replace tasklets with works
To:     Hillf Danton <hdanton@sina.com>
Cc:     rajur@chelsio.com, "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Ivan Vecera <ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 4, 2021 at 5:15 AM Hillf Danton <hdanton@sina.com> wrote:
> Good material to be shoehorned into commit message though without sheding
> any light first on the reasons why CTRL is so special its work wont bothe=
r
> being canceled.

Not sure what you mean. If it's that CTRL work isn't being cancelled,
but OFLD is being cancelled twice, thanks for pointing it. I'm sending
a new patch.

> How long? Long enough for the kworker to become a CPU hog?
> What is it in your opinion to cut the chance for that risk?

I don't think so, not by its own, but the maybe yes the sum of many
tasks in softirq context (it will depend on what else is being
executed in the system). As far as I know, moving work from softirq to
threads to reduce latencies is seen as a good thing, unless it's
really necessary.
--=20
=C3=8D=C3=B1igo Huguet