Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1046177pxj; Fri, 4 Jun 2021 04:56:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGAIjYh8vLqg+K9ufdTgO6e3Ew/3DV2pv5iOflxXODP2mcdrwQwXRmxWNrkoCIGYSI1Vgn X-Received: by 2002:a05:6402:26ce:: with SMTP id x14mr4334615edd.104.1622807788042; Fri, 04 Jun 2021 04:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622807788; cv=none; d=google.com; s=arc-20160816; b=tE6kexmLoOAtNLrLmVhsHzMCiCZ/KiRjv4K4EukLUljfxqehLpdKtBlR9yc0WlDf+c NkoR2pcU/Xjhm7Rdw+eCqYcUo4dmLYgCtZ7qUbe/1EcMUD1qRcrqm8TaWAtgLAlTZ//S UOCXNxSJSqgzBf8bqK6EvvkHT9Lydc6KX2CE2Hpd3LqOEzjNm5JyPOKBWCHT/sVfUqA4 yRMmmc9kz9vIGvllCBj18A6DNaKx1SGtsxYYb2IXOG8RtnfRVqtVkjiiyAyl5Iru0Q7z fv27SR+pkQpvZmCct/JCZNFrbRdMgMM1ZvTOtSSXgyImSif3Vo9SEVhxcyzSg2W+1egw QYrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eLIuvuhTEHo56g5NtvfvXp0safXeM3udSTmjkirYBRk=; b=BTJQWdeMDe3oLirDizw7Ogxf7amj6oGiGq0MOt8mJUkGHQDY23BU8pd+mzpEw+C0PZ gLQRHuEk9E2tgD1QQ+UwUZiQFyRFCMwCeueZKV9hNK/NgQmdT1uIRopTFZh0YZNgKUm3 Nb1aO71EYY4+b/0GlMbq6tV72wWqw3B9eh6EAtTjmBBgbX/nR5HUZ3WuRO/HpEC3r9oK +xHGuDOP4gq0E1HkNhUAiIa7QCnbNJBuMmOuS5V4iCnTtixm9uyJX5rl5ASFDXgUyfHM 70AlMnIkMQ9fxJnUGSFas9E+q0mG4c6gXjlFlR60Q6v6VOdkfrVJqlDtvWcZShDkB/Xv Nq6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G4CIy+pq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si5694829ejl.693.2021.06.04.04.56.04; Fri, 04 Jun 2021 04:56:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G4CIy+pq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbhFDL4j (ORCPT + 99 others); Fri, 4 Jun 2021 07:56:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:45998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbhFDL4g (ORCPT ); Fri, 4 Jun 2021 07:56:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3751561418; Fri, 4 Jun 2021 11:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622807690; bh=wZZG/mGZCjQQr4cb050WrblT+FLO7Xb59hw5tKouVLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G4CIy+pqEcWSE8N1ou8T1exRmZ2BhmHAs5z1o5iTrbZso2KcXVcJnKtaxrVZeb9Ai AJYgJuj7XI7Zp0rUtT4oxLV3QBHNqimHQYnNeUUHmMRcLkJyo8mJEYodpTFODqI2Wj kiyUQV19SLATSESTWjh+tZIdmFuKfs5DejDBMNnE= Date: Fri, 4 Jun 2021 13:54:48 +0200 From: Greg KH To: Wesley Cheng Cc: balbi@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, jackp@codeaurora.org, Thinh.Nguyen@synopsys.com Subject: Re: [PATCH v9 0/5] Re-introduce TX FIFO resize for larger EP bursting Message-ID: References: <1621410561-32762-1-git-send-email-wcheng@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1621410561-32762-1-git-send-email-wcheng@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 12:49:16AM -0700, Wesley Cheng wrote: > Changes in V9: > - Fixed incorrect patch in series. Removed changes in DTSI, as dwc3-qcom will > add the property by default from the kernel. This patch series has one build failure and one warning added: drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_calc_tx_fifo_size’: drivers/usb/dwc3/gadget.c:653:45: warning: passing argument 1 of ‘dwc3_mdwidth’ makes pointer from integer without a cast [-Wint-conversion] 653 | mdwidth = dwc3_mdwidth(dwc->hwparams.hwparams0); | ~~~~~~~~~~~~~^~~~~~~~~~ | | | u32 {aka unsigned int} In file included from drivers/usb/dwc3/debug.h:14, from drivers/usb/dwc3/gadget.c:25: drivers/usb/dwc3/core.h:1493:45: note: expected ‘struct dwc3 *’ but argument is of type ‘u32’ {aka ‘unsigned int’} 1493 | static inline u32 dwc3_mdwidth(struct dwc3 *dwc) | ~~~~~~~~~~~~~^~~ drivers/usb/dwc3/dwc3-qcom.c: In function ‘dwc3_qcom_of_register_core’: drivers/usb/dwc3/dwc3-qcom.c:660:23: error: implicit declaration of function ‘of_add_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] 660 | ret = of_add_property(dwc3_np, prop); | ^~~~~~~~~~~~~~~ | of_get_property How did you test these? thanks, greg k-h