Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Jun 2021 08:58:05 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jason Wang <jasowang@redhat.com>
Cc:     Alex Williamson <alex.williamson@redhat.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Robin Murphy <robin.murphy@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        David Gibson <david@gibson.dropbear.id.au>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC] /dev/ioasid uAPI proposal
Message-ID: <20210604115805.GG1002214@nvidia.com>
References: <20210602111117.026d4a26.alex.williamson@redhat.com>
 <20210602173510.GE1002214@nvidia.com>
 <20210602120111.5e5bcf93.alex.williamson@redhat.com>
 <20210602180925.GH1002214@nvidia.com>
 <20210602130053.615db578.alex.williamson@redhat.com>
 <20210602195404.GI1002214@nvidia.com>
 <20210602143734.72fb4fa4.alex.williamson@redhat.com>
 <6a9426d7-ed55-e006-9c4c-6b7c78142e39@redhat.com>
 <20210603130927.GZ1002214@nvidia.com>
 <65614634-1db4-7119-1a90-64ba5c6e9042@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65614634-1db4-7119-1a90-64ba5c6e9042@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (47.55.113.94) by BL1PR13CA0421.namprd13.prod.outlook.com (2603:10b6:208:2c3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.12 via Frontend Transport; Fri, 4 Jun 2021 11:58:06 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1lp8Sk-001d1T-0A; Fri, 04 Jun 2021 08:58:06 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5a499b51-c25d-413b-52c2-08d927500401
X-MS-TrafficTypeDiagnostic: BL1PR12MB5317:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL1PR12MB53178147482F6ABAA59BB51EC23B9@BL1PR12MB5317.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2FGEa9ZcNBh1kkuJ2BNoZsdlqe8YcKJaj19kzTbLtfbx1ENdhQizQBqdPEclzXxqaiPDx5sD1OZ84Kw5HmjPFz6+gW/CuOovpiAaSlHcQRJAl8d1qVfcOK6RaJ/uJ/aKLxF0D7YHZwhaENimoKSO9XhxvB/UbkwTl4/Wxrk40lnffOOxoUbrk2LS8stBdC3guptfxkReD0GH2iYwgpbG1EeDLUeycU/TppO+XeNJB+YuthePSQM/2QX8JEZChAzSCqz4cKp0uw9tidLP2DSXX2BKGhAkXAmxe0ptZZcX4JW+GotjJspl1eAAZBME7v6AKhq2iTVCCKJZW+b+PXKP6RXWtxiG3Bw23pBUssFsajvrDzLrxpGOWgAEIoUbMX08QDyi8aNXFZ6A8Ea/FxwUpBjVSuvr3wCyVl3T0adYxjGQxSVoPAGx2qHx8o+cjGctCHytAHeGKLzCRz3uZEtF5+rx3vMVAk5cO1/NYH7tp+H01weXU01wyqgczoQkI6cwQCQELJbFlVZN9bfGEyERfd91f8HpBpM8mq2auVr8wEdSpG7Krjhyvgw60Ez7drhDz2E5Yh/cBRB2b4r7CAJ4SYbGSNP8XeofcPlZjEHemig=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(83380400001)(7416002)(33656002)(9786002)(9746002)(8676002)(8936002)(2616005)(2906002)(426003)(38100700002)(316002)(66946007)(66556008)(66476007)(5660300002)(186003)(54906003)(1076003)(4744005)(4326008)(478600001)(36756003)(6916009)(86362001)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?aK1rr0XiDdCDSAJC8t1h3H1htQlX+6EiojOC7hD+d3XZvMygpMsPszZ+VIJk?=
 =?us-ascii?Q?JTOiXAlbNN+I+HsTA35yqQb+G2KYFdOcxyOF+oFH3uPsHw7JXp8Mi1uoPyAu?=
 =?us-ascii?Q?EunLjlBZnt0rl7SbAavwgxtehiom/mFfpiXndYaNfxmY1kXEKOT/lSFGnUWb?=
 =?us-ascii?Q?M7tMKY5qv4UCdn8NnLCylMfXHRBk6XRqLUoJspNIBvTc5FHRAIzjy7ZoAOB+?=
 =?us-ascii?Q?EecHGslHafwx1BGteb4CCgE8kqniNtdIqQlqwISC5sKf+Pe2MiD24JKGMW6D?=
 =?us-ascii?Q?Qx2vw9VWp88vvmjiTnjjwRfVly5wxDC5/zuspmnxiCqzXsRZGe2wQxSAD1V7?=
 =?us-ascii?Q?iu4GEvNPZil6ZUErjmkOme8ddodda8Odmuut8h4rC9GFOyzqkNqkRCW47Otx?=
 =?us-ascii?Q?IhMu3wZLiE138jDLrpgG8bF1RvUFEuxabDenEiz6tc4t1mYreWZxnyS1iB+o?=
 =?us-ascii?Q?9qnLQln2nZYRtg9Skc3Fkyge/hW5Irf6COzG8HijO3LJ6+SFm896G19/4Cy3?=
 =?us-ascii?Q?QObp0ltHY8WKpKVe9s8GXweDQw/umQ3GKXZfVee14P4e8YFBfMOV4Enn+aaZ?=
 =?us-ascii?Q?MAjbEI841v2nmq0AElKwDJWPTOniiwu9m9lipwewOd1UA7uZBKsQ60eSfCVC?=
 =?us-ascii?Q?xW1zN7D1KsSCqKe0g2fDQPCQa0BLOAH1/eGMqceMglSH7i2kwGWBrKgsVr7d?=
 =?us-ascii?Q?0MPwKK2cNgK0VbMYckphPrUDGiK92hqA8ETdYOrKb0qI5Ha1YszclPwiEWsM?=
 =?us-ascii?Q?uyaDmrCTk7B7w8b5jRs7D7h1x/6w71JFtCDSAZR8IZvLmfdKZaAKnperC7TK?=
 =?us-ascii?Q?JZhqw9Ig64n/1M12+RJYKvftW0H1hoASFgOmIraJe5gyLgnNrB2CR1LMLkrJ?=
 =?us-ascii?Q?zsVMAvqa37laOxXQpiqDlvogqXyTiDSyBQMgwmjy4C2oMJ1h/xY+pCtXw4e4?=
 =?us-ascii?Q?xVvk33u7iXplzzMuR2QBTexu/eQtx8B29Um/1870RNx8ujK6K2tDIWw+dQtt?=
 =?us-ascii?Q?e8fkUBfixdo+3ocGENKBcO7wKe2VXGgytpHA9vT4+nUSOw7u6kOD/Tvcfvot?=
 =?us-ascii?Q?r8XuF4vycZ8lBihwqOt1Qv7oCKtpCS0zkcgl0YqcNy+ZZ6+RjdV9nF2cceIf?=
 =?us-ascii?Q?AdbjhHlNvD1PwMUhqVqkhAE6ClBJSxB9rGBm1sRDcfOev4OJfeJTVugvHJPx?=
 =?us-ascii?Q?SsnrJCKKmT1mY+spe9i+0pf4CjhVaLY2CSmKrSgAZsuFtXL2nkVh6v6zVlJ6?=
 =?us-ascii?Q?JXyKOGRLifkEci3Elr/mxzhoNzjBxSiL23nGaRXZyyK6G8g7T3YIBH9F5EwY?=
 =?us-ascii?Q?6a+UqzplYqATx5nmVY8cJfDv?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a499b51-c25d-413b-52c2-08d927500401
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2021 11:58:06.9460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7wC2qmIpa+nXfQbiQyEWed2MVbPRnqZD0ghaZQiASUVdb++x2GNSQ8ygxb9RnQ2L
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5317
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 04, 2021 at 09:11:03AM +0800, Jason Wang wrote:
> > nor do any virtio drivers implement the required platform specific
> > cache flushing to make no-snoop TLPs work.
> 
> I don't get why virtio drivers needs to do that. I think DMA API should hide
> those arch/platform specific stuffs from us.

It is not arch/platform stuff. If the device uses no-snoop then a
very platform specific recovery is required in the device driver.

It is not part of the normal DMA API, it is side APIs like
flush_agp_cache() or wbinvd() that are used by GPU drivers only.

If drivers/virtio doesn't explicitly call these things it doesn't
support no-snoop - hence no VDPA device can ever use no-snoop.

Since VIRTIO_F_ACCESS_PLATFORM doesn't trigger wbinvd on x86 it has
nothing to do with no-snoop.

Jason