Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210604014055.4060521-1-keescook@chromium.org>
 <CACRpkdZEQ+C7tSppcJ83Go70CaBLe4XYKBqYqJfZWAYq-H2+wA@mail.gmail.com> <YLnvIYKduzv56YAA@phenom.ffwll.local>
In-Reply-To: <YLnvIYKduzv56YAA@phenom.ffwll.local>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 4 Jun 2021 15:03:09 +0200
Message-ID: <CACRpkda=5h+NE1xus-ZgT_F2KgUEDPNbhZ4yQd4MyuZ1p+=PDw@mail.gmail.com>
Subject: Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends
To:     Linus Walleij <linus.walleij@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>
Cc:     Daniel Vetter <daniel@ffwll.ch>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 4, 2021 at 11:15 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote:
> > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> > > pl111 is modular. Update the Kconfig to reflect the need.
> > >
> > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
> >
> > Yeah that doesn't work, thanks for fixing this!
> >
> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > > -       depends on VEXPRESS_CONFIG
> > > +       depends on ARM || ARM64 || COMPILE_TEST
> > > +       depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
> >
> > That's the right solution,
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Since I screwed up already, care to also push this to drm-misc-next?

OK I applied and pushed it!

Yours,
Linus Walleij