Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Jun 2021 11:10:31 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Hugh Dickins <hughd@google.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] mm/swap: Fix pte_same_as_swp() not removing uffd-wp bit
 when compare
Message-ID: <YLpCZ6PGxDGt06gQ@t490s>
References: <20210603180546.9083-1-peterx@redhat.com>
 <alpine.LSU.2.11.2106032015250.12760@eggly.anvils>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.11.2106032015250.12760@eggly.anvils>
Precedence: bulk

On Thu, Jun 03, 2021 at 08:26:02PM -0700, Hugh Dickins wrote:
> On Thu, 3 Jun 2021, Peter Xu wrote:
> 
> > I found it by pure code review, that pte_same_as_swp() of unuse_vma() didn't
> 
> Yes, that is an odd corner, easily missed.
> 
> > take uffd-wp bit into account when comparing ptes.  pte_same_as_swp() returning
> > false negative could cause failure to swapoff swap ptes that was wr-protected
> > by userfaultfd.
> > 
> > Cc: Hugh Dickins <hughd@google.com>
> > Cc: Andrea Arcangeli <aarcange@redhat.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> 
> I expect you're right: swapoff used to hang forever (but interruptibly)
> when this went wrong on powerpc originally.  I don't know the uffd_wp
> (nor the soft_dirty) end of it, but treating uffd_wp and soft_dirty
> together looks a very good approach, so I'll venture an
> 
> Acked-by: Hugh Dickins <hughd@google.com>

Thanks!

> 
> But I think it should have a uffd_wp Fixes tag and be Cc stable.

Yes, should be:

Cc: stable@vger.kernel.org # v5.7+
Fixes: f45ec5ff16a7 ("userfaultfd: wp: support swap and page migration")

-- 
Peter Xu