Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V3 7/9] tracing: Add __print_ns_to_secs() and
 __print_ns_without_secs() helpers
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, Phil Auld <pauld@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Kate Carcia <kcarcia@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Clark Willaims <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>, linux-doc@vger.kernel.org
References: <cover.1621024265.git.bristot@redhat.com>
 <2c59beee3b36b15592bfbb9f26dee7f8b55fd814.1621024265.git.bristot@redhat.com>
 <20210603172902.41648183@gandalf.local.home>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
Message-ID: <a343ad15-4deb-ae14-eead-60f7d95fa7d3@redhat.com>
Date:   Fri, 4 Jun 2021 18:07:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210603172902.41648183@gandalf.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/3/21 11:29 PM, Steven Rostedt wrote:
> On Fri, 14 May 2021 22:51:16 +0200
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> 
>> +++ b/include/trace/trace_events.h
>> @@ -358,6 +358,21 @@ TRACE_MAKE_SYSTEM_STR();
>>  	trace_print_hex_dump_seq(p, prefix_str, prefix_type,		\
>>  				 rowsize, groupsize, buf, len, ascii)
>>  
>> +#undef __print_ns_to_secs
>> +#define __print_ns_to_secs(value)			\
>> +	({						\
>> +		u64 ____val = (u64)value;		\
>> +		do_div(____val, NSEC_PER_SEC);		\
>> +		____val;				\
>> +	})
> 
> I know my name is on this, but we need parenthesis around "value".
> 
>> +
>> +#undef __print_ns_without_secs
>> +#define __print_ns_without_secs(value)			\
>> +	({						\
>> +		u64 ____val = (u64)value;		\
> 
> Here too.
> 
>> +		(u32) do_div(____val, NSEC_PER_SEC);	\
>> +	})
>> +
>>  #undef DECLARE_EVENT_CLASS
>>  #define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print)	\
>>  static notrace enum print_line_t					\
>> @@ -736,6 +751,16 @@ static inline void ftrace_test_probe_##call(void)			\
>>  #undef __print_array
>>  #undef __print_hex_dump
>>  
>> +/*
>> + * The below is not executed in the kernel. It is only what is
>> + * displayed in the print format for userspace to parse.
>> + */
>> +#undef __print_ns_to_secs
>> +#define __print_ns_to_secs(val) val / 1000000000UL
>> +
>> +#undef __print_ns_without_secs
>> +#define __print_ns_without_secs(val) val % 1000000000UL
> 
> And around "val" in the above two macros.

Fixing in the v4.

Thanks Steven!
-- Daniel

> -- Steve
> 
>> +
>>  #undef TP_printk
>>  #define TP_printk(fmt, args...) "\"" fmt "\", "  __stringify(args)
>>  
>