Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1257985pxj; Fri, 4 Jun 2021 09:44:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygcifZEoiiFOMfx3f3GyUTYpxdp/ReH8+ZFlM+SuP1zsj88NqL+Q2MCv+ztU0JeJlZ11z3 X-Received: by 2002:a17:906:bb0e:: with SMTP id jz14mr4982436ejb.285.1622825071654; Fri, 04 Jun 2021 09:44:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622825071; cv=none; d=google.com; s=arc-20160816; b=gLSF5/jBH3KjhFpLv5D2B6F0NbsEv7DzQrffnKLmSvJdQJRy26QvV8pXOG5RiqBEFu H6on1lxTZ2z1mIq8oPacIcu/Yk16rtNNNrnQfMdg4pqBlcEuT15DPXc//40qhdGOJBzD lib7vgCk/i++OTrPQ6xFeJV3WlcG3qQn1sI7iozWb5FN+Zfan0IJPAmAojpCHUU5hMvI AhW9mXQ4BGyEYQeW93rkYDzNJPhyFfzBPYoyVldrDXzT7NvpQdnMNl47SnOTSU1bw0KO XDgBY6N+KUq9N/pvm07aYIUj+dAbssyIuJy+G3L0T+sa0ggHEm8C7O0Vki9D9w7eQdf4 4r2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bkBNx6CDCDug1216WbBvCHNO3z3k0uzKIx7Lyd/dMUk=; b=VFyTIS7KQU23mcqf+EuwGtRdhGxM6a1VOWDlUdfHUjrFhzxrAQ4YVVTyd/7vmpKB1u vFgHBC/GyfyQgbYRFbx7XiABVpFmDccSFPnbeFVR6wFAyH/dAFdMH1+l7vQr3QyOMTNm 1F+CWrLKREZ6vipBV66RuapmjekPVN3qT5q+Lj2l6mQXjontlEB95Sbdln3GdWOcqvL9 6Q9Ffcc6PsSx3P45qjXburlQwKltsH0YkxWh4i9NZA3Y7YDf5ZEeY+pmaJi2TifjzGlG IO4FaP7DzbIf0MneVeBtZJXl21A/bd6P5yz81KcaL4BwO7ZwrX8ogguICgcy0LnhlfNk q3Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=QnWXAwxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si5811470edy.327.2021.06.04.09.44.05; Fri, 04 Jun 2021 09:44:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=QnWXAwxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbhFDQoq (ORCPT + 99 others); Fri, 4 Jun 2021 12:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbhFDQop (ORCPT ); Fri, 4 Jun 2021 12:44:45 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFC12C061766 for ; Fri, 4 Jun 2021 09:42:58 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id s70-20020a1ca9490000b02901a589651424so1336297wme.0 for ; Fri, 04 Jun 2021 09:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bkBNx6CDCDug1216WbBvCHNO3z3k0uzKIx7Lyd/dMUk=; b=QnWXAwxqftxBN5G3P0eytpuh1koyN5NIuWZD0EjlOmJ8CwoSbrx47fLH9GKk3cYxEJ wnx1zunVoelHxzcD7ooVRa1wReAhoXHUtv6/oaF84ZsFE8Yg4cLCsWVYD5M5KD2hQMi/ amLmiCR7G1KfqBFzEbi+dKv0q1bjSBFl9kUtjlvaqLXuyHKSsiuiPql0oL7FNMSG+leh mAhm4hSJ8vgmE/FCKB8w89tSzgRHUWU24BhNeM0iEFKQjIfIMOukFYkY1AkqanGvjGHN u6upIrTttgDK1nO/J/+YSGVMwKydGLoTJmHUg3KMnG5RQMSxKCgJE+GNdEmui6TMNb8C Tcaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bkBNx6CDCDug1216WbBvCHNO3z3k0uzKIx7Lyd/dMUk=; b=RK2z+QaPumP5Vdz9NJGcPvn16tl40BLU97xg+Vsy3Sd2mSErvDXg9gVuQUhsm1LHpU gN00tS7JGr8rlrErnN245IdU69u0Brzq/prEbws/e87j2r9b+/rXTuZ7jWIUn2rEa6fW Oo7zngwnEiE3etUDA+euJURrng2fL33r19emKQF2lEEkuC+Yb6H/Qf7MCqbX8uzr9Ytx i0843DkLfYLN/8gxQS9658z+urwMapnBikWumRobf3AQQvkj9Igg4v1j4EC0PbJ2+S8d EQN2KlxzrZV6Fr7kMLjlK3Ow3gaTDjLheuOhMR8lU6nUzOu2bX3MRSXMSmbh14OgvLYW qNhQ== X-Gm-Message-State: AOAM533vNzZBiD/3P9gCR2VwjuU0NQz/TtbseXvpyiOwD+kIG2YVJ4aX 27grum5zrxN+6PoatG5M6kuK1NxcydSUIkSR X-Received: by 2002:a05:600c:2054:: with SMTP id p20mr4217278wmg.175.1622824977481; Fri, 04 Jun 2021 09:42:57 -0700 (PDT) Received: from localhost ([91.110.139.87]) by smtp.gmail.com with ESMTPSA id k16sm5998458wmr.42.2021.06.04.09.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 09:42:57 -0700 (PDT) From: Fam Zheng To: linux-kernel@vger.kernel.org Cc: Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org, fam.zheng@bytedance.com, fam@euphon.net Subject: [PATCH] io_uring: Fix comment of io_get_sqe Date: Fri, 4 Jun 2021 17:42:56 +0100 Message-Id: <20210604164256.12242-1-fam.zheng@bytedance.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sqe_ptr argument has been gone since 709b302faddf (io_uring: simplify io_get_sqring, 2020-04-08), made the return value of the function. Update the comment accordingly. Signed-off-by: Fam Zheng --- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 903458afd56c..bb3685ba335d 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx) } /* - * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory + * Fetch an sqe, if one is available. Note this returns a pointer to memory * that is mapped by userspace. This means that care needs to be taken to * ensure that reads are stable, as we cannot rely on userspace always * being a good citizen. If members of the sqe are validated and then later -- 2.31.1