Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1313954pxj; Fri, 4 Jun 2021 11:04:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1esH+l8JVZeD01jiUVpYfBFYXt7h7GtOfmErPahIaW18k/RFzvoBPIAv4VfPsKu/ZXrye X-Received: by 2002:a05:6402:10c9:: with SMTP id p9mr6069412edu.370.1622829854082; Fri, 04 Jun 2021 11:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622829854; cv=none; d=google.com; s=arc-20160816; b=Zl3hjK+yKcKCgYpgdjhIaahGWpzLtfNxSKcfvWZCDSMLWddWNxtt2XOS1nyArkpGRi RwBnKHFTBEQ7vQDdQE1g6MlGtr3HLZ3AV7cZ0xdVkEezuWCzW1JfDP6yG2Pv/Cy0rkaH MGdkRWheYamnYTxaOw2srdd7l9HqJv9vnmGTYKl83HJNjG7Au2aq/UUE1AMzjPYaL29n rdkAKcMWBX3mMBLKhaGp44tPO3OH0ZXu2bNNQrAhu23SbuQ5qmldZayKhIp/ENLLYiVd 15gg2HHPa2iAPzoVLQ+YbzcZ/SCHOPq2LFUj+060Me8nlGMI1Gom2XH8hWeF2SF87NlH Xi0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pfMgGstv1iK+qTrHiOBb+KFwv6lJ4pEJizPyxTuhpd8=; b=SN4ODxAUnkh+f+Q+DsRjBpfBpBL/e5RR7z/nj6F2SPaxvqPPORIGCPJGIukUzsONTU tQxjFxUoJyC9D6H+zT9Bz0J0zWV4KvEWhZv0rhwff7KNbsYUUIghnGfTO4ZTqlO2KGKW J0H4Zx2fjiga+NQP4VMwJBZBlF/ZMgaB/oORKTpOcLycot7xhoHA3ZURCnGQJV2eYRqh gsz4bdnuUx4zqbMSSrbKlLqUClMf8W5wCR4YCq4Q0IYC7kbXBxCmOPDVWRxW3OLHqKjX 1wSRgn+2jX/SKkvnm2VzdOVIeOoogu0j202SIDHK+F9LxLDsmg7qd0N3UXfeHFBmmMLY QxLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZVv2D1Op; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm25si5101683edb.202.2021.06.04.11.03.28; Fri, 04 Jun 2021 11:04:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZVv2D1Op; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbhFDSBz (ORCPT + 99 others); Fri, 4 Jun 2021 14:01:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbhFDSBz (ORCPT ); Fri, 4 Jun 2021 14:01:55 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ED91C061766 for ; Fri, 4 Jun 2021 10:59:56 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id 69so5051928plc.5 for ; Fri, 04 Jun 2021 10:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pfMgGstv1iK+qTrHiOBb+KFwv6lJ4pEJizPyxTuhpd8=; b=ZVv2D1Opt4rD8W5TQXM6xKheRBRfaWSruA6TejzNbcL1N7POp8z7bUD9U3U9y18Sht VGtOsT2gBDsB//tdzBuHWBfKEhtcDU07bBrSPdLUiD/aoaeyW2dFJJdSOrtcYKUvzUmW cYotmoQ0gUBpWZaUCBjh58Yetu9C5Qk01IppI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pfMgGstv1iK+qTrHiOBb+KFwv6lJ4pEJizPyxTuhpd8=; b=eEGjRonNM7swGZN+WEvKIoR0ouqanxUGs3NA5PRcHtTXo32VINh3dUiM0u4bAnuzBM ziYa4/yTmvnb3iP5aCPTK/0hA1L/deDgur2Uuemyh1vw2fEbQ27CB/bGUWHyASVcYBpx MFGh0F+OvMdPG+V7xUS5FrLkr+bJhUAbWePNd6ux+S1Y768mHMIvNUr3u4cXpUT51sY0 +JTDIjAcB8PAHiqAsTDBn51hZE8pZ0JZYWKLN1/+vUAv1/hdhWvFZZxAPq/ipnudCz1q GYAPXWYlYVN2LhCMo6mT2BO9sOKrxDLlNtp0YRqKOnuQxQZlD0sjjANmISRENEuRIV23 UeFg== X-Gm-Message-State: AOAM533LoUdlKM6E6fcv6PgMpPlKBf0el6jIqYKtjkGQUwtByZlavnQC UglNURqOLYHfpsFoxPDMXBqhQg== X-Received: by 2002:a17:903:1243:b029:107:eca4:d5bf with SMTP id u3-20020a1709031243b0290107eca4d5bfmr5410080plh.15.1622829593519; Fri, 04 Jun 2021 10:59:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o10sm2274012pfh.67.2021.06.04.10.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 10:59:52 -0700 (PDT) From: Kees Cook To: Bill Wendling , Nathan Chancellor , Jarmo Tiitto , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nick Desaulniers , Sami Tolvanen Cc: Kees Cook , morbo@google.com Subject: Re: [PATCH v3 1/1] pgo: Fix allocate_node() v2 Date: Fri, 4 Jun 2021 10:58:38 -0700 Message-Id: <162282951519.3080953.11346638083845350363.b4-ty@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210604165819.7947-1-jarmo.tiitto@gmail.com> References: <20210604165819.7947-1-jarmo.tiitto@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Jun 2021 19:58:20 +0300, Jarmo Tiitto wrote: > When clang instrumentation eventually calls allocate_node() > the struct llvm_prf_data *p argument tells us from what section > we should reserve the vnode: It either points into vmlinux's > core __llvm_prf_data section or some loaded module's > __llvm_prf_data section. > > But since we don't have access to corresponding > __llvm_prf_vnds section(s) for any module, the function > should return just NULL and ignore any profiling attempts > from modules for now. Thanks for working on this! I tweaked the commit title, reflowed the commit log to 80 columns, and adjusted asm-generic to asm. Applied to for-next/clang/features, thanks! [1/1] pgo: Limit allocate_node() to vmlinux sections https://git.kernel.org/kees/c/46773f32ddf1 -- Kees Cook