Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbWKCQrZ (ORCPT ); Fri, 3 Nov 2006 11:47:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753368AbWKCQrZ (ORCPT ); Fri, 3 Nov 2006 11:47:25 -0500 Received: from mtagate5.de.ibm.com ([195.212.29.154]:59081 "EHLO mtagate5.de.ibm.com") by vger.kernel.org with ESMTP id S1753331AbWKCQrY (ORCPT ); Fri, 3 Nov 2006 11:47:24 -0500 From: Thomas Klein Subject: [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix Date: Fri, 3 Nov 2006 17:47:20 +0100 User-Agent: KMail/1.8.2 MIME-Version: 1.0 Content-Disposition: inline X-Length: 1154 To: Jeff Garzik Cc: netdev , "linux-kernel" , "linux-ppc" , "Christoph Raisch" , "Jan-Bernd Themann" , "Jan-Bernd Themann" , Marcus Eder , "Thomas Klein" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200611031747.21667.osstklei@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 27 Fix: Must check for nullpointer before dereferencing it - not afterwards. Signed-off-by: Thomas Klein --- diff -Nurp git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c git.netdev-2.6/drivers/net/ehea/ehea_qmr.c --- git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c 2006-11-03 14:19:51.000000000 +0100 +++ git.netdev-2.6/drivers/net/ehea/ehea_qmr.c 2006-11-03 14:27:53.000000000 +0100 @@ -209,11 +209,11 @@ int ehea_destroy_cq(struct ehea_cq *cq) { u64 adapter_handle, hret; - adapter_handle = cq->adapter->handle; - if (!cq) return 0; + adapter_handle = cq->adapter->handle; + /* deregister all previous registered pages */ hret = ehea_h_free_resource(adapter_handle, cq->fw_handle); if (hret != H_SUCCESS) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/