Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1327454pxj; Fri, 4 Jun 2021 11:24:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxySNmhXXa2Owi4u3lEVJAPIr0tbDBShAMLuD44SjgkEAQbP9Ya7AcmUdtOvpvRfophI6nk X-Received: by 2002:a50:cb85:: with SMTP id k5mr6203894edi.170.1622831058987; Fri, 04 Jun 2021 11:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622831058; cv=none; d=google.com; s=arc-20160816; b=Z1NOuAkNokdNotNKjM+wI2Lz98V9u8B4jPy3Lv2BJj1PPiLSkb1mxg37VhRkQg/p7y G4sbCcfGSckcf3XUR3LewsRGJhYnCHN8sx+8o3SnChfY9NIeG8L6Kl0APvlTJ6Zz9IYB rerj0vf9VmzRfs7DQUGoaPW2RfyLObxL7HR7ncFy3RnOAIF9BaemeWuFoxSZtNsOXp3B qixoXQJVywzq2CXs6sUJmASz2B+tM0fCsl3AVLWf99H+kKj8Wva/SK4r70WPpBCyJwBN WHUQ8fdVC01Ia8pSkG7uss0vTdW2hR/vUxjyiGpTvthzTfKLV6Gu21KEWoT3/ZEW0QAh o0+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=J4cr3GvXSuG4D3gzKE/kKLrguvdOyGMMtXTZNVjyaB8=; b=X/6TD+Ixqnw+uww7JdqGfkxkiZJEPDAPNw26f0HJYgfAIrCK71b1JDRbxC/K9yBKrc H/uvSNymsHvB3qC0PQTa92WDC65T4yGXZa78sZAf7lBB5aUIUITxeBrHpcGGknADE1PH Rb3z73s1bsj12aj69tgrvdBChCx0zkXy0EcbW/LRBZ7l+F7AQaiNIF0UVw3PUWShTdnU ytz0k9wgLoZVbKxxm7BAkqthDBOJ91ylh6qNCtwiTBYsxZW2tvxlQCfRW0ZIiLL/iGRz GLIXvZhsKtXYi50xzGePxx1Ul5lnDNj9k3MC3n4bI0w7DGj/SiSAaiHBZltJXyhx9aAH Gsnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NkPmSJ17; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si5139464ejn.515.2021.06.04.11.23.53; Fri, 04 Jun 2021 11:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NkPmSJ17; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbhFDSXV (ORCPT + 99 others); Fri, 4 Jun 2021 14:23:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbhFDSXU (ORCPT ); Fri, 4 Jun 2021 14:23:20 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8466CC061766 for ; Fri, 4 Jun 2021 11:21:34 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id 11so5069563plk.12 for ; Fri, 04 Jun 2021 11:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=J4cr3GvXSuG4D3gzKE/kKLrguvdOyGMMtXTZNVjyaB8=; b=NkPmSJ17gUmq9yi5wiRooIBIzKdAZstsqbh8VlI/FD1HCoPstrCFA6+fL+Hj6ejXdh 6bk3sGxJH6mEAk5JY9PmL8U96bJ9kF4eBnTY1NxQDR94dfrxRGHeHeSBaLS1qQdc0ZCQ LdUlijfmP2qf+mXtR1DEWDqlQyiZ2ibBzqdbk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=J4cr3GvXSuG4D3gzKE/kKLrguvdOyGMMtXTZNVjyaB8=; b=p+iAj1qTJ5TfnnMAK4OuHvnVJU0q78gugxOTuzmEMHrDB1L+JnVB3AmxEJDImaE/JJ e9zR6y786FSzVszx/g/96lIuSUBtcOKm8/aJlZKfyg8u3qf1cL2O/LF46ebTNyrjvu/q K16UyDyoJo2knhGj6V/mZGWMN+9lks8wCM0WX2Mj3xnoOyXQGxVI6eWmrGQ7hlSvfdSQ OoJs3wgSBQxXfge9ylsVkjidRuE2cjAJMN8m3ZvX9AQf7zwf5D+JAZuqs0sOID692ZdH SYkOpDZm0xA8FCNUTQZ79HcYqo4ebaYiUNiO2asqT4aqNC1Vloy3Q2nfJeOI3GlkM3+X efOw== X-Gm-Message-State: AOAM533ubezZ6TYymM9G4Pc3QZuluRFuGiAjVSVn89795A4O+fp6LT/9 SBioz6/soRmEXoP8exBcv5yhCg== X-Received: by 2002:a17:902:7043:b029:104:8fa9:7443 with SMTP id h3-20020a1709027043b02901048fa97443mr5636864plt.64.1622830894023; Fri, 04 Jun 2021 11:21:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o7sm2773948pgs.45.2021.06.04.11.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 11:21:33 -0700 (PDT) Date: Fri, 4 Jun 2021 11:21:32 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Finn Thain , Michael Schmitz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang Message-ID: <202106041121.990FFB1387@keescook> References: <20210604022752.GA168289@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604022752.GA168289@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 03, 2021 at 09:27:52PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix > a fall-through warning by replacing a /* fallthrough */ comment > with the new pseudo-keyword macro fallthrough; > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Thanks! Reviewed-by: Kees Cook -- Kees Cook