Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1328688pxj; Fri, 4 Jun 2021 11:26:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnk/GAbWFGTvkiPWf1XE6OAGs+murmQAjI8CQbjrmtuZF5viGH2Na2yNH1MWCAtNKDiwVN X-Received: by 2002:a50:ff15:: with SMTP id a21mr6128180edu.103.1622831187830; Fri, 04 Jun 2021 11:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622831187; cv=none; d=google.com; s=arc-20160816; b=MXUF0YmorfTDg+JdPaKXdwxfgxb/p8rXJHgkRM55l9GzHY+f/GZDmQrTau3i8BmXQa A0rswz25PCa19FsTUN/kIZ8aEjP7fBK/gId7HnQL5o+o4mYnMTCfLDqVJhwCHg7F6hLI JhH+WA0YTRqgg6DFBYkDHL+2pFoI7if6wBOzpcd3AtBJ2ZZzl0/nYg6FpwQZf94Jw6M8 dwyR5J+Bq2Op8RccqP8NKP/2G73qdf+ND9iaGeiUuNeU64FtlwoH/bjt/pE5p0LZ5yYJ TSRfvusJYIVRB5JNLLnVhWzCFC4FJcBXQKM46EAQ064+JPNBlOyj61rjjo02PcSrUKY2 7hFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UX1G2MyuSMoI9qtV/IxvY2Ox2XX3g0K693XM4XnGuQs=; b=a57TidNKp8BUcvub+HG6Gj51asKFBcC5bWLK+GByTyB7hUy4hhF4U62rQ21/EmwKZx rKGC3dJ82PZ30bJoiBFFz7oJcwOLnDx2tHy/f3Q+whm4uXZaOG60pFpYemxFjgtUY19d KGQoamqY0JMYiRcOoWp+/sv2r36zetqMSGEkmpPydL+yUeUiznRyZEE6lZutwvWJULS0 K7wUg2MyN26iB6kS4zcufnOdCKRmwlCBmXmyBLLsITgXxyrF3vVee/Iyo9sNK/FKhEpV oleke017/uwWwUw1Ewo7JgydARA/78ns8LNJafh1ezybEdjlsyr6pfijnqCvwJkcKjo2 0BDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=brEmXwIe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr17si4931848ejb.104.2021.06.04.11.25.48; Fri, 04 Jun 2021 11:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=brEmXwIe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhFDSYF (ORCPT + 99 others); Fri, 4 Jun 2021 14:24:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbhFDSYE (ORCPT ); Fri, 4 Jun 2021 14:24:04 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DAE7C061766 for ; Fri, 4 Jun 2021 11:22:18 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id t9so8543204pgn.4 for ; Fri, 04 Jun 2021 11:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UX1G2MyuSMoI9qtV/IxvY2Ox2XX3g0K693XM4XnGuQs=; b=brEmXwIeWk511PUJq83cxnT/omO9wa73pzK4DBRRfyw6IWWvIhLLWGnHkQu0cTXiId osUMl3zdzBrUmpwlIil/zSWrkJ02MAiC0TmLGGOkxs0YiRQNoKaQ23SXe129ISop5J0w psq9IuXjXRSwfDxo+lWbs78DFv2LT0K2q7H8s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UX1G2MyuSMoI9qtV/IxvY2Ox2XX3g0K693XM4XnGuQs=; b=MvEIE+7rjuJwMDKK02h602AIHXqaAcPrTrjmD5vcYGEvG2PfwFRr89kXCsdQfiEJXM y0MMz5q8iv3XSOjjbgyBKE7/jYzjk9FQRj0cQeyZBt5qc96jiHMSMw0sPx304RYfo8Wt 2A03J5l4tNz1nZ25KeOP3Il4srDuRYeYZOn4Ls2HSbLEDWGKxzqQYeL7nxVmQLvP8Dhw bGGpLvWOx6vLMOlPpbglb1EP7s6MUschyOmEq0SNjidvV9huVuG3BAygDqjmJSSlSFm3 bSQ1lwJ/9hZc0E+eYddhlRBudXtp0zOW8RJb3rwl7/tHSChvT6NDcEqzkXPdlNVCIzG+ HMaA== X-Gm-Message-State: AOAM530bdd89McMxuaSEPzzt1/FYucu5oU9dCoxeDHEvwp3fFOnkc5FY d51qd69OyA9QTk1UM6RUsCpoCA== X-Received: by 2002:a62:148e:0:b029:2e4:e5a5:7e33 with SMTP id 136-20020a62148e0000b02902e4e5a57e33mr5846985pfu.9.1622830937626; Fri, 04 Jun 2021 11:22:17 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t13sm2352888pfh.97.2021.06.04.11.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 11:22:17 -0700 (PDT) Date: Fri, 4 Jun 2021 11:22:15 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] scsi: mpi3mr: Fix fall-through warning for Clang Message-ID: <202106041121.41CF254@keescook> References: <20210604023530.GA180997@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604023530.GA180997@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 03, 2021 at 09:35:30PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a > fall-through warning by explicitly adding a break statement instead > of just letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Looks right. Reviewed-by: Kees Cook -- Kees Cook