Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] platform/surface: dtx: Add missing mutex_destroy() call
 in failure path
To:     Maximilian Luz <luzmaximilian@gmail.com>
Cc:     Mark Gross <mgross@linux.intel.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210604132540.533036-1-luzmaximilian@gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <8a317463-5c5f-fd64-f319-1df513e6956a@redhat.com>
Date:   Fri, 4 Jun 2021 21:58:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210604132540.533036-1-luzmaximilian@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/4/21 3:25 PM, Maximilian Luz wrote:
> When we fail to open the device file due to DTX being shut down, the
> mutex is initialized but never destroyed. We are destroying it when
> releasing the file, so add the missing call in the failure path as well.
> 
> Fixes: 1d609992832e ("platform/surface: Add DTX driver")
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

I'll also add this to the fixes branch, so that it gets included
in my next pull-req to Linus for 5.13.

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/surface/surface_dtx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
> index 5d9b758a99bb..1203b9a82993 100644
> --- a/drivers/platform/surface/surface_dtx.c
> +++ b/drivers/platform/surface/surface_dtx.c
> @@ -427,6 +427,7 @@ static int surface_dtx_open(struct inode *inode, struct file *file)
>  	 */
>  	if (test_bit(SDTX_DEVICE_SHUTDOWN_BIT, &ddev->flags)) {
>  		up_write(&ddev->client_lock);
> +		mutex_destroy(&client->read_lock);
>  		sdtx_device_put(client->ddev);
>  		kfree(client);
>  		return -ENODEV;
>