Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/7] platform/surface: aggregator: Allow enabling of
 events without notifiers
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Mark Gross <mgross@linux.intel.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210604134755.535590-1-luzmaximilian@gmail.com>
 <20210604134755.535590-3-luzmaximilian@gmail.com>
 <44e65839-0ee5-98d3-20dd-edfc40f6818e@redhat.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <93470d5d-a720-8ed9-f050-65c16bb0fbca@gmail.com>
Date:   Fri, 4 Jun 2021 22:22:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <44e65839-0ee5-98d3-20dd-edfc40f6818e@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/4/21 10:13 PM, Hans de Goede wrote:
> Hi,
> 
> On 6/4/21 3:47 PM, Maximilian Luz wrote:

[...]

>> +static int ssam_nf_refcount_enable(struct ssam_controller *ctrl,
>> +				   struct ssam_nf_refcount_entry *entry, u8 flags)
>> +{
>> +	const struct ssam_event_registry reg = entry->key.reg;
>> +	const struct ssam_event_id id = entry->key.id;
>> +	struct ssam_nf *nf = &ctrl->cplt.event.notif;
>> +	int status;
>> +
>> +	lockdep_assert_held(&nf->lock);
>> +
>> +	ssam_dbg(ctrl, "enabling event (reg: %#04x, tc: %#04x, iid: %#04x, rc: %d)\n",
>> +		 reg.target_category, id.target_category, id.instance, entry->refcount);
>> +
>> +	if (entry->refcount == 1) {
>> +		status = ssam_ssh_event_enable(ctrl, reg, id, flags);
>> +		if (status)
>> +			return status;
>> +
>> +		entry->flags = flags;
>> +
>> +	} else if (entry->flags != flags) {
>> +		ssam_warn(ctrl,
>> +			  "inconsistent flags when enabling event: got %#04x, expected %#04x (reg: %#04x, tc: %#04x, iid: %#04x)\n",
>> +			  flags, entry->flags, reg.target_category, id.target_category,
>> +			  id.instance);
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +/**
>> + * ssam_nf_refcount_enable() - Disable event for reference count entry if it is
> 
> s/ssam_nf_refcount_enable/ssam_nf_refcount_disable_free/
> 
> No need to resend, I'll fix this up when merging this series.

Oh right, thanks!

Regards,
Max