Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] selftests: timers: rtcpie: skip test if default RTC
 device does not exist
To:     Po-Hsu Lin <po-hsu.lin@canonical.com>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc:     john.stultz@linaro.org, tglx@linutronix.de, sboyd@kernel.org,
        shuah@kernel.org, Shuah Khan <skhan@linuxfoundation.org>
References: <20210525023614.7251-1-po-hsu.lin@canonical.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <d1366904-f297-e995-2a6c-42721f28bc06@linuxfoundation.org>
Date:   Fri, 4 Jun 2021 15:36:12 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210525023614.7251-1-po-hsu.lin@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/21 8:36 PM, Po-Hsu Lin wrote:
> This test will require /dev/rtc0, the default RTC device, or one
> specified by user to run. Since this default RTC is not guaranteed to
> exist on all of the devices, so check its existence first, otherwise
> skip this test with the kselftest skip code 4.
> 
> Without this patch this test will fail like this on a s390x zVM:
> # selftests: timers: rtcpie
> # /dev/rtc0: No such file or directory
> not ok 1 selftests: timers: rtcpie # exit=22
> 
> With this patch:
> # selftests: timers: rtcpie
> # Default RTC /dev/rtc0 does not exist. Test Skipped!
> not ok 9 selftests: timers: rtcpie # SKIP
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---

Thank you for the patch. Will pick this up for 5.14

thanks,
-- Shuah