Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        David Howells <dhowells@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     linux-afs@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
References: <20210305091900.GA139713@embeddedor>
 <7137db63-20ea-29b2-7b8e-e2edd0c42bdd@embeddedor.com>
Message-ID: <e34e5b36-fc3d-3abf-34a5-0963cce25059@embeddedor.com>
Date:   Fri, 4 Jun 2021 17:35:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <7137db63-20ea-29b2-7b8e-e2edd0c42bdd@embeddedor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:09, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping: who can take this, please?
> 
> Thanks
> --
> Gustavo
> 
> On 3/5/21 03:19, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>>  net/rxrpc/af_rxrpc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
>> index 41671af6b33f..2b5f89713e36 100644
>> --- a/net/rxrpc/af_rxrpc.c
>> +++ b/net/rxrpc/af_rxrpc.c
>> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
>>  	switch (rx->sk.sk_state) {
>>  	case RXRPC_UNBOUND:
>>  		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
>> +		break;
>>  	case RXRPC_CLIENT_UNBOUND:
>>  	case RXRPC_CLIENT_BOUND:
>>  		break;
>>