Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] perf annotate: Add itrace options support
To:     <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
        <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
        <jolsa@redhat.com>, <namhyung@kernel.org>,
        <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210527015510.5719-1-yangjihong1@huawei.com>
From:   Yang Jihong <yangjihong1@huawei.com>
Message-ID: <2193a839-076a-3b5e-8ded-395531310d96@huawei.com>
Date:   Sat, 5 Jun 2021 08:33:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210527015510.5719-1-yangjihong1@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

ping :)

Please take time to review this patch.

Thanks,
Yang

On 2021/5/27 9:55, Yang Jihong wrote:
> The "auxtrace_info" and "auxtrace" functions are not set in "tool" member of
> "annotate". As a result, perf annotate does not support parsing itrace data.
> 
> A simple example is as follows:
> 
>    # perf record -e arm_spe_0/branch_filter=1/ -a sleep 1
>    [ perf record: Woken up 9 times to write data ]
>    [ perf record: Captured and wrote 20.874 MB perf.data ]
>    # perf annotate --stdio
>    Error:
>    The perf.data data has no samples!
> 
> Solution:
> 1.Add itrace options in help,
> 2.Set hook functions of "auxtrace_info" and "auxtrace" in perf_tool.
> 
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> ---
>   tools/perf/builtin-annotate.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 49627a7bed7c..84ef52177d63 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -474,6 +474,8 @@ int cmd_annotate(int argc, const char **argv)
>   			.attr	= perf_event__process_attr,
>   			.build_id = perf_event__process_build_id,
>   			.tracing_data   = perf_event__process_tracing_data,
> +			.auxtrace_info	 = perf_event__process_auxtrace_info,
> +			.auxtrace	 = perf_event__process_auxtrace,
>   			.feature	= process_feature_event,
>   			.ordered_events = true,
>   			.ordering_requires_timestamps = true,
> @@ -483,6 +485,9 @@ int cmd_annotate(int argc, const char **argv)
>   	struct perf_data data = {
>   		.mode  = PERF_DATA_MODE_READ,
>   	};
> +	struct itrace_synth_opts itrace_synth_opts = {
> +		.set = 0,
> +	};
>   	struct option options[] = {
>   	OPT_STRING('i', "input", &input_name, "file",
>   		    "input file name"),
> @@ -547,6 +552,9 @@ int cmd_annotate(int argc, const char **argv)
>   	OPT_CALLBACK(0, "percent-type", &annotate.opts, "local-period",
>   		     "Set percent type local/global-period/hits",
>   		     annotate_parse_percent_type),
> +	OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",
> +			    "Instruction Tracing options\n" ITRACE_HELP,
> +			    itrace_parse_synth_opts),
>   
>   	OPT_END()
>   	};
> @@ -591,6 +599,8 @@ int cmd_annotate(int argc, const char **argv)
>   	if (IS_ERR(annotate.session))
>   		return PTR_ERR(annotate.session);
>   
> +	annotate.session->itrace_synth_opts = &itrace_synth_opts;
> +
>   	annotate.has_br_stack = perf_header__has_feat(&annotate.session->header,
>   						      HEADER_BRANCH_STACK);
>   
>