Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] power: reset/supply: add missing
 MODULE_DEVICE_TABLE
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
CC:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1620896701-53542-1-git-send-email-zou_wei@huawei.com>
 <20210604110221.ykclr6yxlw3nflug@earth.universe>
From:   Samuel Zou <zou_wei@huawei.com>
Message-ID: <527f34eb-364f-ac4c-a918-610d8f2cd190@huawei.com>
Date:   Sat, 5 Jun 2021 08:48:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20210604110221.ykclr6yxlw3nflug@earth.universe>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi Sebastian,

Thanks for your review, I will split the patch into three and resend soon.
On 2021/6/4 19:02, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, May 13, 2021 at 05:05:01PM +0800, Zou Wei wrote:
>> This patch adds missing MODULE_DEVICE_TABLE definition which generates
>> correct modalias for automatic loading of this driver when it is built
>> as an external module.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>> ---
> 
> Does not apply anymore. Also please split this into three patches,
> one for regulator-poweroff, one for ab8500 and one for
> charger-manager.
> 
> Thanks,
> 
> -- Sebastian
> 
>>   drivers/power/reset/regulator-poweroff.c | 1 +
>>   drivers/power/supply/ab8500_btemp.c      | 1 +
>>   drivers/power/supply/ab8500_charger.c    | 1 +
>>   drivers/power/supply/ab8500_fg.c         | 1 +
>>   drivers/power/supply/charger-manager.c   | 1 +
>>   5 files changed, 5 insertions(+)
>>