Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210604015640.2586269-1-shakeelb@google.com> <20210604061816.3110-1-hdanton@sina.com>
 <20210605015421.5096-1-hdanton@sina.com> <YLriZxiWo+2hMI7g@slm.duckdns.org>
In-Reply-To: <YLriZxiWo+2hMI7g@slm.duckdns.org>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Fri, 4 Jun 2021 21:45:28 -0700
Message-ID: <CALvZod6AydanksvciHuxRPoOddFX3ov0Pp511RkzO8nLn3TJUQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] memcg: periodically flush the memcg stats
To:     Tejun Heo <tj@kernel.org>
Cc:     Hillf Danton <hdanton@sina.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Michal Hocko <mhocko@kernel.org>, Roman Gushchin <guro@fb.com>,
        =?UTF-8?Q?Michal_Koutn=C3=BD?= <mkoutny@suse.com>,
        Huang Ying <ying.huang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 4, 2021 at 7:33 PM Tejun Heo <tj@kernel.org> wrote:
>
> On Sat, Jun 05, 2021 at 09:54:21AM +0800, Hillf Danton wrote:
> > The cond_resched() in cgroup_rstat_flush_locked() matches its appearence in
> > your post [1]. So does unbound IMHO.
>
> Ah yeah, this either needs CPU_INTENSIVE or UNBOUND, prolly the latter is
> better.
>

I will change the next version to the system_unbound_wq.