Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <454425.1622838810@turing-police>
In-Reply-To: <454425.1622838810@turing-police>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 5 Jun 2021 17:19:30 +0900
Message-ID: <CAK7LNATbWnduSfqehJ7yMjxCbkrM87aojDCdQ79J+kXiTaZ-fQ@mail.gmail.com>
Subject: Re: x86 - weird cross-compile build problem with try-run next-20210602
To:     =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jun 5, 2021 at 5:33 AM Valdis Kl=C4=93tnieks <valdis.kletnieks@vt.e=
du> wrote:
>
> I built a gcc 11.1 cross-compiler targeting x86_64, and builds
> were throwing an error message:
>
> Makefile:149: CONFIG_X86_X32 enabled but no binutils support
>
> so I added some debugging to arch/x86/Makefile:
>
> ifdef CONFIG_X86_X32
>         x32_ld_ok :=3D $(call try-run,\
>                         /bin/echo -e '1: .quad 1b' | \
>                         $(CC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP"=
 - && \
>                         $(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMP.o" && \
>                         $(LD) -m elf32_x86_64 "$$TMP.o" -o "$$TMP",y,n)
>  $(warning x32_ld_ok is +$(x32_ld_ok)+ with CC=3D$(CC) $(KBUILD_AFLAGS) O=
BJ=3D$(OBJCOPY) LD=3D$(LD) )
>         ifeq ($(x32_ld_ok),y)
>                 CONFIG_X86_X32_ABI :=3D y
>
> and that throws:
>
> arch/x86/Makefile:143: x32_ld_ok is ++ with CC=3Dx86_64-unknown-linux-gnu=
-gcc -D__ASSEMBLY__ -fno-PIE -m64 OBJ=3Dx86_64-unknown-linux-gnu-objcopy LD=
=3Dx86_64-unknown-linux-gnu-ld
>
> Anybody have a clue why $(x32_ld_ok)  is null rather than 'y' or 'n'?


What command did you run?

I see this warning message for 'make install' for example.

$ make install
arch/x86/Makefile:148: CONFIG_X86_X32 enabled but no binutils support


Please add one more debug line:
  $(warning need-compiler is +$(need-compiler)+)
and what will you get?


One quick fix is to change

    ifeq ($(x32_ld_ok),y)

to

   ifneq ($(x32_ld_ok),n)

But, I think moving this check to Kconfig
is a more proper fix.


> (It's totally possible that my cross-compiler is broken, but I still don'=
t see how
> try-run would return null rather than 'n' in that case...  I built a shel=
l script that did the
> test and that ended with $? =3D=3D 0, but had a warning msg:
>
> + /bin/echo -e '1: .quad 1b'
> + x86_64-unknown-linux-gnu-gcc -D__ASSEMBLY__ -fno-PIE -m64 -c -x assembl=
er -o /tmp/z97 -
> + x86_64-unknown-linux-gnu-objcopy -O elf32-x86-64 /tmp/z97 /tmp/z99.o
> + x86_64-unknown-linux-gnu-ld -m elf32_x86_64 /tmp/z99.o -o /tmp/z98
> x86_64-unknown-linux-gnu-ld: warning: cannot find entry symbol _start; de=
faulting to 0000000000401000
> echo $?
> + echo 0
> 0
>
>
>


--=20
Best Regards
Masahiro Yamada