Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1739442pxj; Sat, 5 Jun 2021 01:31:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIR47DvhHkHxSzTpSPgpZGtbkMHXpkqUcwZ+ava7LacUI0EmoTtEcIEgDSl3TvN9u7rlat X-Received: by 2002:a17:906:c311:: with SMTP id s17mr8102335ejz.202.1622881906796; Sat, 05 Jun 2021 01:31:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622881906; cv=none; d=google.com; s=arc-20160816; b=ngNG11jTgJCRv31K/8NoElFbYMLChC0LaUVbbXts36/UT8LaTPmCP+m7HlAZ0dbbG3 63gUwG71xeOlIZB1ASp94fNpy0bxFSNQIl3IAr1rTUQ9dbXVii+sH1adrIQ/yy2KXjwS uSUciJH809O+YDc+td6Thiz7gcpMEGy/vAxNqAjs5Roaqf4du1FXynWGZkoPkClq2lf6 59Nd5poSVsLL2euLieE1aw0j74t6aDKFcvaGZvAdPlT3B2cAYXwLUxydgKmoyNWDEHSr LocKH/tI5DFH56+2MZRu5gdvP0Bpvxwa9UO2Twe/S0inFyoRnN3fMXsFWBtY2Glhky/Z bTgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=F8Cwhp6d7JMz0kTF1RuzXvuenRKxESQxsVJZeyEgs9M=; b=LV9lj5v30IxsN67e6D6/DnZpRzlpePNqAa39tLgVSKybyDPHtukOSX74mU0T2V0Ad3 5ZRInXOJKKVigFXeXhzFDOnegNddLqd+FxaT9h4W8aXXno3bdXPFac4cMWgUohU0KfgR uXrdIG3viiBDLoCQdPlSZLDxy4GlGYYIYTFdkrImiqxGj4zjGjrWTzVWYZciiItEq1iB l3zvMv3GQAo1AijtncjJdwKIkzlfMPXua1WhmOmyvbgu59EeUbMTyqAs1113ra58qDGI eoph4mV3QNTXmmoVHmXKKGPKQ5RjPrAt+OZZE5NiCdV9YCFWVGBYWlUd2XYLnVbwkR2e +ZHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si8403350ejc.125.2021.06.05.01.31.23; Sat, 05 Jun 2021 01:31:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbhFEI2D (ORCPT + 99 others); Sat, 5 Jun 2021 04:28:03 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44290 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbhFEI2A (ORCPT ); Sat, 5 Jun 2021 04:28:00 -0400 Received: from 36-226-165-123.dynamic-ip.hinet.net ([36.226.165.123] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lpRd4-0001D3-EE; Sat, 05 Jun 2021 08:26:03 +0000 From: Jeremy Szu To: tiwai@suse.com Cc: Jeremy Szu , Jaroslav Kysela , Kailang Yang , Hui Wang , Jian-Hong Pan , Chris Chiu , Huacai Chen , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8 Date: Sat, 5 Jun 2021 16:25:38 +0800 Message-Id: <20210605082539.41797-3-jeremy.szu@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210605082539.41797-1-jeremy.szu@canonical.com> References: <20210605082539.41797-1-jeremy.szu@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The HP EliteBook 840 Aero G8 using ALC285 codec which using 0x04 to control mute LED and 0x01 to control micmute LED. In the other hand, there is no output from right channel of speaker. Therefore, add a quirk to make it works. Signed-off-by: Jeremy Szu --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 11324163ebe1..215beb3ac678 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8330,6 +8330,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), -- 2.31.1