Subject: Re: [PATCH 1/2] Add Legacy IDE mode support for SB600 SATA
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Luugi Marsan <luugi.marsan@amd.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20061103185420.B3FA6CBD48@localhost.localdomain>
References: <20061103185420.B3FA6CBD48@localhost.localdomain>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Fri, 03 Nov 2006 19:30:16 +0000
Message-Id: <1162582216.12810.40.camel@localhost.localdomain>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 985
Lines: 17

Ar Gwe, 2006-11-03 am 13:54 -0500, ysgrifennodd Luugi Marsan:
> From: conke.hu@amd.com
> 
> ATI SB600 SATA controller supports 4 modes: Legacy IDE, Native IDE, AHCI and RAID.IDE modes are used for compatibility with some old OS without AHCI driver,but now they are not necessary for Linux since the kernel has supported AHCI.Some BIOS set Legacy IDE as SB600 SATA's default mode, but the AHCI driver cannot run in Legacy IDE.So, we should set the controller back to AHCI mode if it has been set as IDE by BIOS.
> 
> Signed-off-by:  Luugi Marsan <luugi.marsan@amd.com>

NAK

This should only be done if AHCI is configured into the kernel, so wants
a #ifdef check adding. Otherwise people using SB600 via the legacy ide
layer will get burned.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/