Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1785518pxj; Sat, 5 Jun 2021 03:04:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysfvqUPysjvxZe7Os6xeOSBwZie6u5PXsNiqKi84rgVmGN5y0nOXO7zBJKa877VZNg5a8T X-Received: by 2002:a05:6402:14d8:: with SMTP id f24mr494552edx.79.1622887490744; Sat, 05 Jun 2021 03:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622887490; cv=none; d=google.com; s=arc-20160816; b=kAtLCQUAPsfO1rak8Y7JB2aVOFUSST6oJqBYUH5GDBM0qIwC3/rB3RwDGTu7tNuLDo ZFhAEqjQI0R9KIWhGmlYAutqF0S4+R2zRChYOIUhWxesm5pEHnFlJFK5s5MCiarLv5CU fv2yVIwLiEz72R7k9zaIjnJjSaNO9hwfDLDzWjSfD1bTYo4Q77pU1KwNgG89TVLXoVok fww7YuJ3Ytd9DZdfDVzzrlUafGKetCeDFepQK4lN48J958lJcwYZLQaj3FqE7rOqApoi bHvv0iUwnHxru3HEdRTQXF404JtovZh+o/zJScnXTCRBLHqM/jNUO4egrNyOI7utu2uH bzJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=aTujzxd1MS06uuSNiZEqMtHJdI751kT66UmzXchv3Kc=; b=VppIC4/eQD7OHDexO/oJbu6sOCmbXkUa5FuM63GTK/C+YNL2Zeudd4k/ZhuJLac14r h9+T8O5y2eqFEPhfSbZBPI8o/OZhl6n/7CKXTqnRX3tAkEzp4VP8vajjjEVTFaNmYH6d 2CFMk16jUcXqf2U2J9BbGj6lhSZ+5qregZW4Zhkx2VtiekDujvybMAaGoofCY10xOYy7 fbUyAvOOgrlIyepOsTN4X03/EI5cwpocitXN6dTmFAYS5UDTrlVHg3F4WIy3G76jUGqq eY3xdYpnw/8jgfi50zMxDwP4rYr/pVFiHR0nsWeuJa9K2MoFn3wjbDgd0apo6lj6IKeu P19Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l21si8192741edw.553.2021.06.05.03.04.26; Sat, 05 Jun 2021 03:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbhFEKEF (ORCPT + 99 others); Sat, 5 Jun 2021 06:04:05 -0400 Received: from fgw22-7.mail.saunalahti.fi ([62.142.5.83]:45748 "EHLO fgw22-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbhFEKEE (ORCPT ); Sat, 5 Jun 2021 06:04:04 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id dc745646-c5e2-11eb-88cb-005056bdf889; Sat, 05 Jun 2021 12:46:12 +0300 (EEST) Date: Sat, 5 Jun 2021 12:46:11 +0300 From: andy@surfacebook.localdomain To: Linus Walleij Cc: Andy Shevchenko , Pavel Machek , Amireddy Mallikarjuna reddy , Abanoub Sameh , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Linux LED Subsystem , linux-kernel Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe() Message-ID: References: <20210529111935.3849707-1-andy.shevchenko@gmail.com> <20210529111935.3849707-12-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Jun 01, 2021 at 12:06:05PM +0200, Linus Walleij kirjoitti: > On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko > wrote: > > > fwnode_get_next_available_child_node() bumps a reference counting of > > a returned variable. We have to balance it whenever we return to > > the caller. > > > > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver") > > Cc: Linus Walleij > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Linus Walleij Thanks! Pavel, can you, please, review this batch? I think I addressed most of your comments if not all. -- With Best Regards, Andy Shevchenko