Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 5 Jun 2021 10:40:21 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Haiyang Zhang <haiyangz@microsoft.com>, bhelgaas@google.com,
        lorenzo.pieralisi@arm.com, linux-hyperv@vger.kernel.org,
        linux-pci@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de,
        vkuznets@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in
 init_hv_pci_drv()
Message-ID: <20210605104021.amywuuhlyesgmybw@liuwe-devbox-debian-v2>
References: <20210602103206.4nx55xsl3nxqt6zj@liuwe-devbox-debian-v2>
 <20210604212622.GA2241239@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210604212622.GA2241239@bjorn-Precision-5520>
Precedence: bulk

On Fri, Jun 04, 2021 at 04:26:22PM -0500, Bjorn Helgaas wrote:
> On Wed, Jun 02, 2021 at 10:32:06AM +0000, Wei Liu wrote:
> > On Tue, May 25, 2021 at 04:17:33PM -0700, Haiyang Zhang wrote:
> > > Add check for hv_is_hyperv_initialized() at the top of init_hv_pci_drv(),
> > > so if the pci-hyperv driver is force-loaded on non Hyper-V platforms, the
> > > init_hv_pci_drv() will exit immediately, without any side effects, like
> > > assignments to hvpci_block_ops, etc.
> > > 
> > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > Reported-and-tested-by: Mohammad Alqayeem <mohammad.alqyeem@nutanix.com>
> > 
> > Hello PCI subsystem maintainers, are you going to take this patch or
> > shall I?
> 
> This was mistakenly assigned to me, so I reassigned it back to
> Lorenzo.
> 
> If you *do* take this, please at least update it to follow the PCI
> commit log conventions, e.g.,
> 
>   PCI: hv: Add check ...
> 
> and wrap the text so it fits in 75 columns.

Lorenzo already picked up two Hyper-V PCI patches from Long Li. I think
leaving this to him is better.

Wei.