Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1860066pxj; Sat, 5 Jun 2021 05:25:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrkErDR4oRHZlSR/Fp7ReY/KC+fKGlUpRfm78f2WaLiWOwjuRp/V5Jp6KccUlzr5uFOQ0E X-Received: by 2002:a05:6402:3585:: with SMTP id y5mr10046884edc.121.1622895944178; Sat, 05 Jun 2021 05:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622895944; cv=none; d=google.com; s=arc-20160816; b=uo5b8emMJbaRsebAW0GPPU8LjXMMh9c9vdp1rfD+12toZYZqeH/iMvxsdxCHj5SJ4r wupaVOApp2EFNSIeM9HZTXXyWR05+VVtvhSyjp6fn4h0uxB9xFMPqE5lOMHvc74m42mj 0CcEhN9YrFZTJ3PTrwe8giUwZ/7kPcdFfYsGFrKxIHJKeu+oFP9svjiZJ3sTHOmwi7Xr QXKX6ejk4+C0TbQLAVYbD6P5ZyvoSjbJqhyC/PVftFtd+o4u29esjbc8oGb9Ijb1xld2 07PuYDrFCBc7AiCu4Z0QSucJpXvHt0kOojE7pmlvz3Z39pk7P8B5YWH1p7SoxCF0rqAt TLRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=exAJJRAiR6UD6FzwqV8cifkC4ICNOa0GP2nAKGnWY3U=; b=nsnD5al391n5nP4t7kVg37W2UnWTfgHKazX0QKakUBrQPnC1inFvS8m3NlA2KKsd6K qLktEK6MJKO77tLIHSNrdBsnrcXsIU3JDy649k57TFOd7npk8a7aufRYF4K6Kdp9NSDg 9kSVmTbbRPqp4/DkGyeM/6J4XdFTmdBQMuqFvS6uLRwRQjNsE5/y/e2Z3MQ2xpCBQ0qo 6K8iYUHzPX/OAsIPCvB1vIvvLg3F+YLPWTsNx6v3Mw0zghbJhOGpEJQ9OZEbMHVzInt4 NekoJ0sqW5awW/MMZ9Eb6CASpD2y/jM1Y+/byJUhM8ntRw2y/5P++ew+Z24c855SpE7M 4Oig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m14si7188746edp.172.2021.06.05.05.25.20; Sat, 05 Jun 2021 05:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbhFEM0G (ORCPT + 99 others); Sat, 5 Jun 2021 08:26:06 -0400 Received: from mail-m17639.qiye.163.com ([59.111.176.39]:38988 "EHLO mail-m17639.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbhFEM0G (ORCPT ); Sat, 5 Jun 2021 08:26:06 -0400 Received: from ubuntu.localdomain (unknown [36.152.145.181]) by mail-m17639.qiye.163.com (Hmail) with ESMTPA id E8CCA380170; Sat, 5 Jun 2021 20:24:16 +0800 (CST) From: Bernard Zhao To: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Bernard Zhao Subject: [PATCH] drm/etnaviv: remove no need NULL check Date: Sat, 5 Jun 2021 05:24:14 -0700 Message-Id: <20210605122415.8621-1-bernard@vivo.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZGkxCHVZJSx5KH0IeQh4fSk9VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWUFZT0tIVUpKS0 hKQ1VLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NSo6Kzo6Nz8LEQk*IR4qCA44 ChAKCTFVSlVKTUlJQ0JOQ05MT0pMVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlITVVK TklVSk9OVUpDSllXWQgBWUFJS0tCNwY+ X-HM-Tid: 0a79dc218dfed994kuwse8cca380170 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before kvfree functions is not needed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index d05c35994579..bd0d66ebf314 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds: if (ret && (out_fence_fd >= 0)) put_unused_fd(out_fence_fd); - if (stream) - kvfree(stream); - if (bos) - kvfree(bos); - if (relocs) - kvfree(relocs); - if (pmrs) - kvfree(pmrs); + kvfree(stream); + kvfree(bos); + kvfree(relocs); + kvfree(pmrs); return ret; } -- 2.31.0