Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194
Mime-Version: 1.0
Message-Id: <89b391d1-c076-491a-97c0-d08593c006e7@www.fastmail.com>
In-Reply-To: <d50ad9392f7719c01f752e73a00d4dc83b1a5c5c.camel@pengutronix.de>
References: <20210603085003.50465-1-sven@svenpeter.dev>
 <20210603085003.50465-4-sven@svenpeter.dev>
 <d50ad9392f7719c01f752e73a00d4dc83b1a5c5c.camel@pengutronix.de>
Date:   Sat, 05 Jun 2021 14:28:27 +0200
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Rouven Czerwinski" <r.czerwinski@pengutronix.de>,
        "Will Deacon" <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        "Joerg Roedel" <joro@8bytes.org>,
        "Rob Herring" <robh+dt@kernel.org>
Cc:     "Arnd Bergmann" <arnd@kernel.org>, devicetree@vger.kernel.org,
        "Hector Martin" <marcan@marcan.st>, linux-kernel@vger.kernel.org,
        "Marc Zyngier" <maz@kernel.org>,
        "Mohamed Mediouni" <mohamed.mediouni@caramail.com>,
        "Stan Skowronek" <stan@corellium.com>,
        linux-arm-kernel@lists.infradead.org,
        "Mark Kettenis" <mark.kettenis@xs4all.nl>,
        "Petr Mladek via iommu" <iommu@lists.linux-foundation.org>,
        "Alexander Graf" <graf@amazon.com>
Subject: Re: [PATCH v3 3/3] iommu: dart: Add DART iommu driver
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rouven,

On Sat, Jun 5, 2021, at 13:50, Rouven Czerwinski wrote:
> Hi Sven,
>=20
> just a small comment, see inline.
>=20
> On Thu, 2021-06-03 at 10:50 +0200, Sven Peter wrote:
> > +
> > +/* must be called with held dart_domain->lock */
>=20
> You can remove this comment, include lockdep.h and=E2=80=A6
>=20
> > +static int apple_dart_finalize_domain(struct iommu_domain *domain)
> > +{
> > +	struct apple_dart_domain *dart_domain =3D to_dart_domain(domain);
> > +	struct apple_dart *dart =3D dart_domain->dart;
> > +	struct io_pgtable_cfg pgtbl_cfg;
> > +
>=20
> 	lockdep_assert_held(&dart_domain->lock);
>=20
> A lockdep enabled kernel will warn if this function is called without
> the lock held, otherwise this gets optimized out. Same for the similar=

> comments below.
>=20

That looks very useful, thanks! Will use it for v4.

I only found assert_spin_locked originally but didn't want to have that
performance overhead for code that (I hope :-)) correctly uses these fun=
ctions
with a held lock right now.


Thanks,


Sven