From: Andi Kleen <ak@suse.de>
To: Amul Shah <amul.shah@unisys.com>
Subject: Re: [RFC] [PATCH 2.6.19-rc4] kdump panics early in boot when   reserving MP Tables located in high memory
Date: Fri, 3 Nov 2006 20:52:05 +0100
User-Agent: KMail/1.9.5
Cc: vgoyal@in.ibm.com, LKML <linux-kernel@vger.kernel.org>,
       Fastboot mailing list <fastboot@lists.osdl.org>
References: <1162506272.19677.33.camel@ustr-linux-shaha1.unisys.com> <20061103171757.GC9371@in.ibm.com> <1162583277.19677.108.camel@ustr-linux-shaha1.unisys.com>
In-Reply-To: <1162583277.19677.108.camel@ustr-linux-shaha1.unisys.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200611032052.05738.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 806
Lines: 21

On Friday 03 November 2006 20:47, Amul Shah wrote:

> Andi, Vivek is right.  We can use end_pfn_map.  My observation is wrong.

Ok. Then my patch should work?

> Vivek, the problem condition is in generic reserve_bootmem_core
> (mm/bootmem.c), where this
> 	BUG_ON(PFN_DOWN(addr) >= bdata->node_low_pfn);
> checks the target address against the top of that node's memory.

In general these early BUGs should be eliminated - they are always
messy because the kernel exception handlers are not fully functional
yet. printks or worst case panics are better.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/