Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210601213143.1973770-1-helgaas@kernel.org> <819816a2-be1a-8d63-a26b-31f8caa8c944@infradead.org>
In-Reply-To: <819816a2-be1a-8d63-a26b-31f8caa8c944@infradead.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 5 Jun 2021 23:47:37 +0900
Message-ID: <CAK7LNARSxkAJp_PmW2wnZeadQq30UXJY+4hGFmTm5X=sxMPr1Q@mail.gmail.com>
Subject: Re: [PATCH] kconfig.h: explain IS_MODULE(), IS_ENABLED()
To:     Randy Dunlap <rdunlap@infradead.org>,
        Bjorn Helgaas <helgaas@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Paul Cercueil <paul@crapouillou.net>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 2, 2021 at 6:53 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 6/1/21 2:31 PM, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Extend IS_MODULE() and IS_ENABLED comments to explain why one might use
> > "#if IS_ENABLED(CONFIG_FOO)" instead of "#ifdef CONFIG_FOO".
> >
> > To wit, "#ifdef CONFIG_FOO" is true only for CONFIG_FOO=y, while
> > "#if IS_ENABLED(CONFIG_FOO)" is true for both CONFIG_FOO=y and
> > CONFIG_FOO=m.
> >
> > This is because "CONFIG_FOO=m" in .config does not result in "CONFIG_FOO"
> > being defined.  The actual definitions are in autoconf.h, where:
> >
> >   CONFIG_FOO=y   results in   #define CONFIG_FOO 1
> >   CONFIG_FOO=m   results in   #define CONFIG_FOO_MODULE 1
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>


Applied to linux-kbuild. Thanks.


> Thanks.
>
> > ---
> >  include/linux/kconfig.h | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h
> > index cc8fa109cfa3..20d1079e92b4 100644
> > --- a/include/linux/kconfig.h
> > +++ b/include/linux/kconfig.h
> > @@ -51,7 +51,8 @@
> >
> >  /*
> >   * IS_MODULE(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'm', 0
> > - * otherwise.
> > + * otherwise.  CONFIG_FOO=m results in "#define CONFIG_FOO_MODULE 1" in
> > + * autoconf.h.
> >   */
> >  #define IS_MODULE(option) __is_defined(option##_MODULE)
> >
> > @@ -66,7 +67,8 @@
> >
> >  /*
> >   * IS_ENABLED(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'y' or 'm',
> > - * 0 otherwise.
> > + * 0 otherwise.  Note that CONFIG_FOO=y results in "#define CONFIG_FOO 1" in
> > + * autoconf.h, while CONFIG_FOO=m results in "#define CONFIG_FOO_MODULE 1".
> >   */
> >  #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
> >
> >
>
>
> --
> ~Randy
>


-- 
Best Regards
Masahiro Yamada