Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1622898327.git.mchehab+huawei@kernel.org> <63fe86c8de5cced00a1bb5d18d6c7f087268565a.1622898327.git.mchehab+huawei@kernel.org>
In-Reply-To: <63fe86c8de5cced00a1bb5d18d6c7f087268565a.1622898327.git.mchehab+huawei@kernel.org>
From:   David Gow <davidgow@google.com>
Date:   Sat, 5 Jun 2021 23:43:55 +0800
Message-ID: <CABVgOS=vcZX5w4tyQg9nsDyJ0sKdS-McgVNzVd9mqeLy1NTCFA@mail.gmail.com>
Subject: Re: [PATCH 13/34] docs: dev-tools: testing-overview.rst: avoid using
 ReSt :doc:`foo` markup
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Daniel Latypov <dlatypov@google.com>,
        Marco Elver <elver@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jun 5, 2021 at 9:18 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> The :doc:`foo` tag is auto-generated via automarkup.py.
> So, use the filename at the sources, instead of :doc:`foo`.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---

Hmm... I'd originally wanted this to read more like the name of the
tool than the path to the doc file, but given the :doc: prefix and
backticks are equally ugly, and no less confusing to the plain-text
reader than the filename, I'm happy to have this changed. Particularly
if we're standardising on this across the kernel documentation.

Reviewed-by: David Gow <davidgow@google.com>


-- David

>  Documentation/dev-tools/testing-overview.rst | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/dev-tools/testing-overview.rst b/Documentation/dev-tools/testing-overview.rst
> index b5b46709969c..65feb81edb14 100644
> --- a/Documentation/dev-tools/testing-overview.rst
> +++ b/Documentation/dev-tools/testing-overview.rst
> @@ -71,15 +71,15 @@ can be used to verify that a test is executing particular functions or lines
>  of code. This is useful for determining how much of the kernel is being tested,
>  and for finding corner-cases which are not covered by the appropriate test.
>
> -:doc:`gcov` is GCC's coverage testing tool, which can be used with the kernel
> -to get global or per-module coverage. Unlike KCOV, it does not record per-task
> -coverage. Coverage data can be read from debugfs, and interpreted using the
> -usual gcov tooling.
> +Documentation/dev-tools/gcov.rst is GCC's coverage testing tool, which can be
> +used with the kernel to get global or per-module coverage. Unlike KCOV, it
> +does not record per-task coverage. Coverage data can be read from debugfs,
> +and interpreted using the usual gcov tooling.
>
> -:doc:`kcov` is a feature which can be built in to the kernel to allow
> -capturing coverage on a per-task level. It's therefore useful for fuzzing and
> -other situations where information about code executed during, for example, a
> -single syscall is useful.
> +Documentation/dev-tools/kcov.rst is a feature which can be built in to the
> +kernel to allow capturing coverage on a per-task level. It's therefore useful
> +for fuzzing and other situations where information about code executed during,
> +for example, a single syscall is useful.
>
>
>  Dynamic Analysis Tools
> --
> 2.31.1
>