Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jarmo Tiitto <jarmo.tiitto@gmail.com>
To:     Jarmo Tiitto <jarmo.tiitto@gmail.com>,
        Kees Cook <keescook@chromium.org>
Cc:     Sami Tolvanen <samitolvanen@google.com>,
        Bill Wendling <wcw@google.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
        morbo@google.com
Subject: Re: [PATCH v3 1/1] pgo: Fix allocate_node() v2
Date:   Sat, 05 Jun 2021 20:15:29 +0300
Message-ID: <2268220.EOMg9uvDZY@hyperiorarchmachine>
In-Reply-To: <202106041104.929FFB3@keescook>
References: <20210604165819.7947-1-jarmo.tiitto@gmail.com> <202106041104.929FFB3@keescook>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

> Kees Cook wrote perjantaina 4. kes=C3=A4kuuta 2021 21.06.37 EEST:
> >=20
> > I grep -R'd where the memory_contains() can be found and it is only
> > found in #include <asm-generic/sections.h>
>=20
> That's true, but the way to use "asm-generic" is to include the
> top-level "asm" file, so that architectures can override things as
> needed.
>=20
Thanks, I didn't know that.

> > I cross my fingers and await if this is my first accepted patch. :-)
>=20
> I tweaked it a bit and applied it (see the separate email).
>=20
> Thank you!
>=20
> -Kees
>=20
> --=20
> Kees Cook
>=20

Whoa!=20
Thanks, I'm glad it worked out. :-)

Btw. I have almost forgotten that I once wrote code=20
(that I didn't send) for the GCC gcov subsystem that also enabled=20
=2Dfprofile-generate/use for the kernel.
However the Clang PGO looks much more approachable and
easier to hack on since the profile data format is simpler.

So starting to work on this felt just natural to me. :-)

=2DJarmo