Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210603140700.3045298-1-yukuai3@huawei.com>
In-Reply-To: <20210603140700.3045298-1-yukuai3@huawei.com>
From:   Andrey Konovalov <andreyknvl@gmail.com>
Date:   Sat, 5 Jun 2021 23:15:16 +0300
Message-ID: <CA+fCnZewY8MNf1fWaTg0VLwSivEejn1-msRXiuy7WGXApfBJYQ@mail.gmail.com>
Subject: Re: [PATCH] kasan: fix doc warning in init.c
To:     Yu Kuai <yukuai3@huawei.com>
Cc:     Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, yi.zhang@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 3, 2021 at 4:58 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  mm/kasan/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index c4605ac9837b..348f31d15a97 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
>  /**
>   * kasan_populate_early_shadow - populate shadow memory region with
>   *                               kasan_early_shadow_page
> - * @shadow_start - start of the memory range to populate
> - * @shadow_end   - end of the memory range to populate
> + * @shadow_start: start of the memory range to populate
> + * @shadow_end: end of the memory range to populate
>   */
>  int __ref kasan_populate_early_shadow(const void *shadow_start,
>                                         const void *shadow_end)
> --
> 2.31.1

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>