Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2144002pxj;
        Sat, 5 Jun 2021 14:35:28 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJySy0ZwtGvsFbVw3ujRGUCN5i50RAk7mtcSbqw5FDB96OYQoRk0rCdIQm/pfqOKaOMUBn6V
X-Received: by 2002:aa7:cfc5:: with SMTP id r5mr12052506edy.319.1622928928230;
        Sat, 05 Jun 2021 14:35:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1622928928; cv=none;
        d=google.com; s=arc-20160816;
        b=YJ3Atjd4aSi2NAka1XGQaU4XOUGnF/SsIQJ6fMaEFZ3fkYnSI/VoljrqX70BVaV9ps
         M+c3sNxkvPgxB4rqoc2v9tAf2ZWO5hCLHcXmAIWEmbufrefkdO6Br3Kpe5I7O+zdiNmp
         coYNaDJYA5dtyy/2eSf9U57sDfVhaXv6/Dpg8W+r3oYnLJL6iyQE3zim3A8tKi9M1yK5
         7xY/U/P1Ie6ZDk33w3L/Il5FuhzBR8xWx70dB6wsLj0D9+I+hDwoR4/7zGHrAZRCSkdN
         TAhdYgrH1JYnNbdBTBDkeX4+y90WEXA/iMMsc3J1b0GrD7Fq6sRC/K6PUWlA9OQfPfUu
         uRhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:to:subject:message-id:date:user-agent:from
         :references:in-reply-to:mime-version:dkim-signature;
        bh=nDGVMkwUgwdjkEH0hG7ASi22La0UWmLtqIvR+gpN50c=;
        b=GG7Lh45pDIGIQAY3s1BBk/guIW5OUbIbx5koMVve9epOxi37HtR/GDJ9AHvvSx8w1r
         0bAz7UT/R/frhzfVc2Nabh8ZGVU7HsxOF5niXgGWX0fWI6XJmkyuXcdEbNC5pr9nfBfX
         3VGvaEmKpUCwN6NaWuUm5npmTjS0Mbx+nyzlsf9xKWDhEPcnLlfIT6t6e2pkaNZFD4yC
         DmjSe6u03YlbjoidBCRuJI/igfxzms5psYZ+LBAR3WMPH/zmDf1X3yQ/cm9/t+9eiabr
         EzbO2PW6nGq7ABHLLyks42HsCDHLWxFu9MRcndTao0DmROkOvdCY78dFuXA7GkTeSihD
         GI3A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@chromium.org header.s=google header.b=BTK1W0Vg;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id bh4si9795250ejb.358.2021.06.05.14.35.05;
        Sat, 05 Jun 2021 14:35:28 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@chromium.org header.s=google header.b=BTK1W0Vg;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230104AbhFEV2l (ORCPT <rfc822;luscent@gmail.com> + 99 others);
        Sat, 5 Jun 2021 17:28:41 -0400
Received: from mail-oi1-f181.google.com ([209.85.167.181]:33665 "EHLO
        mail-oi1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229998AbhFEV2l (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 5 Jun 2021 17:28:41 -0400
Received: by mail-oi1-f181.google.com with SMTP id t140so8474068oih.0
        for <linux-kernel@vger.kernel.org>; Sat, 05 Jun 2021 14:26:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=chromium.org; s=google;
        h=mime-version:in-reply-to:references:from:user-agent:date:message-id
         :subject:to;
        bh=nDGVMkwUgwdjkEH0hG7ASi22La0UWmLtqIvR+gpN50c=;
        b=BTK1W0VgQTwdsUqPJC2JMeWQHe/oG0sV0uSI7t/AuJN4FhyLldkvR/V50OgZ1WkQ3Y
         E2KIBDbE8jzDxK1L8GQj9FHWF9sbHqjk03gw52+j1vksR4WcFb8pBAhOtA6ILoPRRF/5
         Fu0bRbfzhLXQVRZQLg4nMWzU19aRBMl0wGMo8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from
         :user-agent:date:message-id:subject:to;
        bh=nDGVMkwUgwdjkEH0hG7ASi22La0UWmLtqIvR+gpN50c=;
        b=EWnUsOiXRW5iMkGaho+S2Bn8K1/bEWMk43wpb0PwCm0MC3rOZu3+gdmjBFsq5UmiL8
         2FTm3kharCHzFFV+VpqUz1PjfiQp786xfJpu5/LjgtSBVpGPEKhNlVfrph279/oaJPOs
         dXfDMbg5nslLV41cjzNvj0WoFAyimNePUXS9gptT+uKJ2NBOHJpITFYwj3dPTue9Q7P2
         miTuKJsZj+nwPPCMZZ5s7v7cjrJxHJXzTmrlF7mrz2O64Zpo2b4DyIb9zG0Y00FJFIQx
         v5w/M6dCjC3L6zx3l8DdXAWH5pYOE5Y8Y2+gD+lL8LUdmbDSRpL8lp4vfIPbfSpdWJUP
         EiVQ==
X-Gm-Message-State: AOAM533OmpMtqUzthXOjCvsDOeN90hu8NYE5wCdrp0AOzudZfE4z5NPl
        oIradm6DyFP4X43rI7iZqgPBHKKS0jhk2599Qz8+Ug==
X-Received: by 2002:a05:6808:144e:: with SMTP id x14mr15519145oiv.166.1622928340013;
 Sat, 05 Jun 2021 14:25:40 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 5 Jun 2021 21:25:39 +0000
MIME-Version: 1.0
In-Reply-To: <20210605123543.8986-1-bernard@vivo.com>
References: <20210605123543.8986-1-bernard@vivo.com>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.9.1
Date:   Sat, 5 Jun 2021 21:25:39 +0000
Message-ID: <CAE-0n513KEA+_5m=X1EKjnAbVVAeGXADqJ+S=Hs+E9cr7gEzJQ@mail.gmail.com>
Subject: Re: [PATCH] drm/msm: remove no need local variable
To:     Abhinav Kumar <abhinavk@codeaurora.org>,
        Bernard Zhao <bernard@vivo.com>,
        Chandan Uddaraju <chandanu@codeaurora.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Guenter Roeck <groeck@chromium.org>,
        Kuogee Hsieh <khsieh@codeaurora.org>,
        Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Bernard Zhao (2021-06-05 05:35:20)
> Unneeded variable: "ret". Return "0" on line 880

But the variable is "rc".

>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---

Otherwise

Reviewed-by: Stephen Boyd <swboyd@chromium.org>