Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2234013pxj; Sat, 5 Jun 2021 18:11:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhJOuGRTmlI9HvLBtPgfBCRH8xxxr2uHQn30YeVS1tCkgC1CYnrpQm607gJmOrJ//y0FQu X-Received: by 2002:aa7:c782:: with SMTP id n2mr12756063eds.77.1622941890889; Sat, 05 Jun 2021 18:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622941890; cv=none; d=google.com; s=arc-20160816; b=pMiBYOCVlL4GiLxvzzyDYxAib/9PoOuCpqZFvKkdgvnTqoEWqVPA5wnskSFMjKAkuf Z06swa43GOR1gqB7qDLzpZR9NQSF+WB92mY2/9GvsYrs52DybN+bF9/oauwmrzrxeOBE ziAjbR8Pv/GZaHfPTKvRB4vQh7MKpBaf6ZmDELKbnKqdk9Yr3fQW8LLnd5hRnjbYKEWo 0rWllDwHTDeYT1oyvp7sunZ4bXTLmndcPrh5OmgqlBxn9ZYtT+01M2AAsPx4o4iRbpKn JuddPO9OForUpmV686OggwLtRHHOTQrDctAf3v0QEwXPiXbzbjptbLMBJb5CwbQiE7M1 Gdyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:date:cc:to:from:subject:message-id; bh=CQqEV7S9CrJ4wcUrEyp9lfbOQU5IPTpPTMGqkITX/JI=; b=rbVXNfKSgvuP+qrHQuczacT4XuNaFe9HEdO5jhThGGAvFt/ll439PGRUaLqzH+Moa+ Kq9U+LWUoJKaacP0LUOxrr4+p2Fdq3b5qa+/uHIYKRLDfsQuGFmCSXLUl6sJxYFAE41i Wv3UdFYU+ckZaetB0gvX8yUar+LMzVb6ZmO3gnFC6FclmX26QxdhCudS4uLYbP61XRCP vFyzrr7S6c2cPgfz2clCLVhAh4H5kFHPGPNjyepl+1Hmlt3mswkCaVqhHWzFRkmWI/4r QrSy070YK2YVoGwJ2gVoZ61bPBC7AzP3xHP7Ss4WJMxbhIExCweNumJrCg6Zw9xYNG0c ATuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si8723040ejd.87.2021.06.05.18.11.07; Sat, 05 Jun 2021 18:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbhFFBMC (ORCPT + 99 others); Sat, 5 Jun 2021 21:12:02 -0400 Received: from smtprelay0100.hostedemail.com ([216.40.44.100]:53090 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230022AbhFFBMC (ORCPT ); Sat, 5 Jun 2021 21:12:02 -0400 Received: from omf15.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 17133100E7B43; Sun, 6 Jun 2021 01:10:13 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA id 03FE4C4178; Sun, 6 Jun 2021 01:10:11 +0000 (UTC) Message-ID: <9e07e80d8aa464447323670fd810f455d53f76f3.camel@perches.com> Subject: irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ? From: Joe Perches To: Mustafa Ismail Cc: Shiraz Saleem , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, LKML Date: Sat, 05 Jun 2021 18:10:10 -0700 Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 03FE4C4178 X-Spam-Status: No, score=1.10 X-Stat-Signature: skjieu6c8if6fmcgcrgx6a1j5q95zjrb X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+Pv7iUn8+XZ8iroSvbZ5WUjQz4ljaBJp4= X-HE-Tag: 1622941811-105777 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are some odd mismatches in field and access index. These may be simple cut/paste typos. Are these intentional? ip4txfrag is set to the value from IP4RXFRAGS 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1753) gather_stats->ip4txfrag = 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1754) rd64(dev->hw, 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1755) dev->hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP4RXFRAGS] 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1756) + stats_inst_offset_64); ip4txfrag is set again a few lines later, so the case above is probably a defect. 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1769) gather_stats->ip4txfrag = 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1770) rd64(dev->hw, 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1771) dev->hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP4TXFRAGS] 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1772) + stats_inst_offset_64); And here ip6txfrag is set to the value of IP6RXFRAGS 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1785) gather_stats->ip6txfrags = 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1786) rd64(dev->hw, 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1787) dev->hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP6RXFRAGS] 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1788) + stats_inst_offset_64);