Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Muchun Song <songmuchun@bytedance.com>
To:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH] mm: slub: replace local_irq_save with local_irq_disable
Date:   Sun,  6 Jun 2021 12:17:50 +0800
Message-Id: <20210606041750.69403-1-songmuchun@bytedance.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The caller of slub_cpu_dead cannot be irq disabled (because slab_mutex is
holding during the processing), there is no need to use irq_save. Just use
irq_disable directly.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
 mm/slub.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index ee51857d8e9b..fbf592ef14ff 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2529,13 +2529,12 @@ static void flush_all(struct kmem_cache *s)
 static int slub_cpu_dead(unsigned int cpu)
 {
 	struct kmem_cache *s;
-	unsigned long flags;
 
 	mutex_lock(&slab_mutex);
 	list_for_each_entry(s, &slab_caches, list) {
-		local_irq_save(flags);
+		local_irq_disable();
 		__flush_cpu_slab(s, cpu);
-		local_irq_restore(flags);
+		local_irq_enable();
 	}
 	mutex_unlock(&slab_mutex);
 	return 0;
-- 
2.11.0