Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Sun, 6 Jun 2021 08:04:45 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     Jason Wang <jasowang@redhat.com>
CC:     <mst@redhat.com>, <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] vdpa/mlx5: Clear vq ready indication upon device reset
Message-ID: <20210606050445.GA189356@mtl-vdi-166.wap.labs.mlnx>
References: <20210603081026.5640-1-elic@nvidia.com>
 <9ec6480d-3eee-c644-2a06-8a180aa9fb07@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9ec6480d-3eee-c644-2a06-8a180aa9fb07@redhat.com>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2021 05:04:51.1503
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1df698a6-9944-447d-495f-08d928a89dad
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT021.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3585
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 04, 2021 at 10:34:29AM +0800, Jason Wang wrote:
> 
> 在 2021/6/3 下午4:10, Eli Cohen 写道:
> > After device reset, the virtqueues are not ready so clear the ready
> > field.
> > 
> > Failing to do so can result in virtio_vdpa failing to load if the device
> > was previously used by vhost_vdpa and the old values are ready.
> > virtio_vdpa expects to find VQs in "not ready" state.
> > 
> > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > ---
> > v0 --> v1:
> >    Make sure clear of ready is done only in reset flow
> > 
> >   drivers/vdpa/mlx5/net/mlx5_vnet.c | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index 02a05492204c..eaeae67e0ff0 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -1766,6 +1766,14 @@ static void teardown_driver(struct mlx5_vdpa_net *ndev)
> >   	mutex_unlock(&ndev->reslock);
> >   }
> > +static void clear_vqs_ready(struct mlx5_vdpa_net *ndev)
> > +{
> > +	int i;
> > +
> > +	for (i = ndev->mvdev.max_vqs - 1; i >= 0; i--)
> > +		ndev->vqs[i].ready = false;
> 
> 
> The patch looks correct but I wonder the reason for the decreasing used in
> the loop.

No special reason. I just copy pasted it from somewhere else in the
code. Will post another version.
> 
> Usually, it means it has some reason that must be done in that way.
> 
> Thanks
> 
> 
> > +}
> > +
> >   static void mlx5_vdpa_set_status(struct vdpa_device *vdev, u8 status)
> >   {
> >   	struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
> > @@ -1776,6 +1784,7 @@ static void mlx5_vdpa_set_status(struct vdpa_device *vdev, u8 status)
> >   	if (!status) {
> >   		mlx5_vdpa_info(mvdev, "performing device reset\n");
> >   		teardown_driver(ndev);
> > +		clear_vqs_ready(ndev);
> >   		mlx5_vdpa_destroy_mr(&ndev->mvdev);
> >   		ndev->mvdev.status = 0;
> >   		ndev->mvdev.mlx_features = 0;
>