Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
Date:   Sun, 6 Jun 2021 14:34:11 +0200
From:   Salvatore Bonaccorso <carnil@debian.org>
To:     Greg KH <greg@kroah.com>
Cc:     =?utf-8?Q?Lauren=C8=9Biu_P=C4=83ncescu?= <lpancescu@gmail.com>,
        stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Backporting fix for #199981 to 4.19.y?
Message-ID: <YLzAw27CQpdEshBl@eldamar.lan>
References: <c75fcd12-e661-bc03-e077-077799ef1c44@gmail.com>
 <YLiNrCFFGEmltssD@kroah.com>
 <5399984e-0860-170e-377e-1f4bf3ccb3a0@gmail.com>
 <YLiel5ZEcq+mlshL@kroah.com>
 <addc193a-5b19-f7f3-5f26-cdce643cd436@gmail.com>
 <YLpJyhTNF+MLPHCi@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YLpJyhTNF+MLPHCi@kroah.com>
Precedence: bulk

Hi Laurențiu, Greg,

On Fri, Jun 04, 2021 at 05:42:02PM +0200, Greg KH wrote:
> On Fri, Jun 04, 2021 at 04:50:19PM +0200, Laurențiu Păncescu wrote:
> > Hi Greg,
> > 
> > On 6/3/21 11:19 AM, Greg KH wrote:
> > > That commit does not apply cleanly and I need a backported version.  Can
> > > you do that and test it to verify it works and then send it to us to be
> > > applied?
> > 
> > I now have a patch against linux-4.19.y, tested on my EeePC just now: the
> > battery status and discharge rate are shown correctly.
> > 
> > I've never submitted a patch before, should I put "commit <short-hash>
> > upstream." as the first line of my commit message, followed by another line
> > stating which branch I would like this to be merged to? Should I also
> > include the original commit message of the backported commit? And then use
> > git format-patch? I just read through [1] and [2], but they don't say
> > anything specific about commit messages for backported patches.
> 
> Yes, what you describe here should be great.  Look at the stable mailing
> list archives on lore.kernel.org for other examples of this happening,
> https://lore.kernel.org/r/20210603162852.1814513-1-zsm@chromium.org is
> one example.

Instead of doing a specific backport, maybe it is enough to pick
a46393c02c76 ("ACPI: probe ECDT before loading AML tables regardless
of module-level code flag") frst on 4.19.y and then the mentioned fix
b1c0330823fe ("ACPI: EC: Look for ECDT EC after calling
acpi_load_tables()").

Note I have only checked that this resolved the clean apply on top of
the current v4.19.193.

Regards,
Salvatore