Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2580168pxj; Sun, 6 Jun 2021 07:00:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgFPLU4+sg5Kk1vuqae3b5DxoZ+bKjitKnIdkHgeDHlhKX68Np0A7tV7/qtOnoNJEgAMqh X-Received: by 2002:a17:906:158c:: with SMTP id k12mr13661121ejd.274.1622988058680; Sun, 06 Jun 2021 07:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622988058; cv=none; d=google.com; s=arc-20160816; b=fpF4HAm+zwecCUSBzU13qZf3jv55voYRa37YK95ZQ9rcTrXS/5QX3eEsdAafsz8Xnz CjV5gMEYLRsYUDwJ2hmSHNSHtEI78yUVX45L20OkE84cVyPvzGBzYSo/l3wflg0KWmJv ljjSmyBemtBjaE70BtX2fJJprOFOeSHOCiyCvo+BJP66PDecqAfihKjV1+GM2G69Wduj W+U9Okx4TFeGlx2f5WS9xYFp/rn4Ukao7HUKRD5HpaSY0wpwaCBKlYfDVuBST7ak+7VG Q20YYA5EArmd5mxPM0qOmFGf4JLAfAWauFoXwusM5EDDREzPvLPns3fr4/5L+K7bA/lZ QsfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version; bh=lD4Ow3NxkMzyWtViZFLO2R8Tn+cqI4bxcqPaDPz9dtI=; b=Y6FjUymHIzUepj/P5tBp6diwMvlMhYQ8rCtlcHldOG91vuV46H1e/LuvbVqtO1AK90 Uys/9alJmQnRHACX8+ZqdiBP7Qqaois0aB7SML23QwyOQ5Tu2/uuIYY85p5tqfhD0U8F YXPQMobifyDYy4iqZeFVaBi/CiGums5B2CwFiHoofN/MTucrV2SHs1PevO8lh3kVIe9d 64i0mMki6u+dE0zmiJqImFRyLLRf7JpDUI3yWxEdxlgk1cgb18IsAsslKBs6YBDK0fFa l0gplts6GLKLJBrzJyiyrFUoJ+t7jfB+mchYHQNRCjqPK9g1mTPaWv1faniBn8picLqa QSMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si9798987ejl.598.2021.06.06.07.00.35; Sun, 06 Jun 2021 07:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbhFFN7F (ORCPT + 99 others); Sun, 6 Jun 2021 09:59:05 -0400 Received: from disco-boy.misterjones.org ([51.254.78.96]:48616 "EHLO disco-boy.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbhFFN7D (ORCPT ); Sun, 6 Jun 2021 09:59:03 -0400 X-Greylist: delayed 1842 seconds by postgrey-1.27 at vger.kernel.org; Sun, 06 Jun 2021 09:59:02 EDT Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lpsnB-005lcJ-9b; Sun, 06 Jun 2021 14:26:17 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sun, 06 Jun 2021 14:26:17 +0100 From: Marc Zyngier To: Sandor Bodo-Merle Cc: Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Pali_Roh=C3=A1r?= Subject: Re: [PATCH 1/2] PCI: iproc: fix the base vector number allocation for multi-MSI In-Reply-To: <20210606123044.31250-1-sbodomerle@gmail.com> References: <20210606123044.31250-1-sbodomerle@gmail.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <473f3d7dd4252f14629be63dc220cd7e@misterjones.org> X-Sender: maz@misterjones.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sbodomerle@gmail.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pali@kernel.org X-SA-Exim-Mail-From: maz@misterjones.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-06 13:30, Sandor Bodo-Merle wrote: > Commit fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs") > introduced multi-MSI support with a broken allocation mechanism (it > failed > to reserve the proper number of bits from the inner domain). Natural > alignment of the base vector number was also not guaranteed. > > Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs") > Reported-by: Pali Rohár > Signed-off-by: Sandor Bodo-Merle Acked-by: Marc Zyngier M. -- Who you jivin' with that Cosmik Debris?