Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2638394pxj; Sun, 6 Jun 2021 08:49:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCP6w23tPk0Pk98kX0OGj3gmlpu+WM2J9lnh6lnA+NJZrRaTLOS7yIveOAFLvo15DwgkR8 X-Received: by 2002:a17:906:aac9:: with SMTP id kt9mr4394036ejb.162.1622994550218; Sun, 06 Jun 2021 08:49:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622994550; cv=none; d=google.com; s=arc-20160816; b=GxjOdO7o36p2exb/7NEQ1DHNR8a9DbfIWBcOf1aU58ErMWQorb4gjAW0fyjLkoxM2D I/BXcUNvXiJVBAno1eEVapqNhMwO+8kbY5fhEc+LpLDOXw4FcHGcpSbRUP0pLpjH4JVq Qxi6yBtrx3DgTbRgd8pIiZRKEm1e2WMVYl25UeiEIrAKoLs9nPx15ViOSWsHbTM2wbAE O7svmZ78agh0zWgBssolKlGKpcNJwcu1jRXp8bs/k9N3IoLt4xOCe2HKIEbagB7vekFz 5aKSD6GhG+bpzsYEo7qkO3th8Q9slGjwclUp9c3xrOwjCUUf0kXg60Squagb1RRhSgrS LLwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=tLH/Ld3x4p+KGyBunB14YrfcGi3GFVfZ111O+PyXwRE=; b=ZhL/d1+NS/8NNHiB+J4CZxcNsS+yGWUKjUUcWeb2NtfLj6mBAH7y2gWZNYQbOholrY i8USPQG+e7pXJWxZihtJ6hdEwAODBACYb6D3bEZDPkE9Dq/GTAjlh/rgvgqWw2kkXxAZ 5SqQi58HPKVXm7sX3lrKAc676hu5pxkWeyJmS+cQgp2yKio+GGb5WFPmUkJUScsVg4BB 0OgreBV70eKKf6kYlc3FnZgmf2WvXr8znJXm38bhb20pfpuTDy7Nmeaf/wS5dQZI79Q4 wNNOimX3YOIOf+tFbaLTRpP2dtsQPVlB9QGT6pttDrHXO6nxgghhM1TZu8aiHvNT1QGO cS7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f26si10300337ejf.128.2021.06.06.08.48.47; Sun, 06 Jun 2021 08:49:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbhFFPs0 (ORCPT + 99 others); Sun, 6 Jun 2021 11:48:26 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:53975 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbhFFPsV (ORCPT ); Sun, 6 Jun 2021 11:48:21 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d04 with ME id DrmV2500P21Fzsu03rmVAo; Sun, 06 Jun 2021 17:46:30 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 06 Jun 2021 17:46:30 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: spock@gentoo.org, adaplas@gmail.com, akpm@linux-foundation.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] video: fbdev: uvesafb: Fixes an error handling path in 'uvesafb_probe()' Date: Sun, 6 Jun 2021 17:46:28 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a successful 'uvesafb_init_mtrr()' call, it must be undone by a corresponding 'arch_phys_wc_del()' call, as already done in the remove function. This has been added in the remove function in commit 63e28a7a5ffc ("uvesafb: Clean up MTRR code") Fixes: 8bdb3a2d7df4 ("uvesafb: the driver core") Signed-off-by: Christophe JAILLET --- Unsure about the Fixes tag, maybe it is 63e28a7a5ffc --- drivers/video/fbdev/uvesafb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 4df6772802d7..a7e606520dfc 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1757,6 +1757,7 @@ static int uvesafb_probe(struct platform_device *dev) out_unmap: iounmap(info->screen_base); + arch_phys_wc_del(par->mtrr_handle); out_mem: release_mem_region(info->fix.smem_start, info->fix.smem_len); out_reg: -- 2.30.2