Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RESEND net-next 1/2] net: hns3: add support for PTP
To:     Richard Cochran <richardcochran@gmail.com>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
        <lipeng321@huawei.com>, <tanhuazhong@huawei.com>
References: <1622602664-20274-1-git-send-email-huangguangbin2@huawei.com>
 <1622602664-20274-2-git-send-email-huangguangbin2@huawei.com>
 <20210603132237.GC6216@hoboy.vegasvil.org>
 <a60de68c-ca2e-05e9-2770-a4d3ecb589ae@huawei.com>
 <20210605155330.GB10328@localhost>
From:   "huangguangbin (A)" <huangguangbin2@huawei.com>
Message-ID: <47805689-2c52-ea26-49a6-3fbe3aa22a88@huawei.com>
Date:   Mon, 7 Jun 2021 10:44:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20210605155330.GB10328@localhost>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/6/5 23:53, Richard Cochran wrote:
> On Sat, Jun 05, 2021 at 06:37:19PM +0800, huangguangbin (A) wrote:
>>> Need mutex or spinlock to protest against concurrent access.
>>>
>> Ok, thank you. Is it better to add mutex or spinlock in the public place, like ptp_clock_adjtime()?
>> Then there's no need to add mutex or spinlock in all the drives.
> 
> No, that is a terrible idea.  The class layer has no idea about the
> hardware implementation.  Only the driver knows that.
> 
> Thanks,
> Richard
> .
> 
Ok, thanks. We will add mutex or spinlock as your idea, and repost a new version after we test ok.