Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2976357pxj; Sun, 6 Jun 2021 21:45:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXcq8JTY6ae3vu0c6IBIQ6n+vlrfpILsogv3WQGRcDcE4+aogMNn54DEOKnnE7Qr6ndhK4 X-Received: by 2002:a17:906:7f0e:: with SMTP id d14mr15917236ejr.103.1623041135686; Sun, 06 Jun 2021 21:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623041135; cv=none; d=google.com; s=arc-20160816; b=UTnByLRfyrFck9iz6+eYE6tkNr9FZyrAEutxmnfs6GswRTFXkVGt2Or1Ka5uP/2g7C VPs/rruV3irnQBFmT+cXHi0T81MiLGDsguSgjHwHKZVWWxbVNyPVgWI8HEbogLFaMnE5 fPTT58Pe1H9Piy+VrIK/+GMi8O9Xqcl8LSMxRv4/XvWuWjW4uuLIxGv7yK4uhhPuKrzH dY1pcwsopsEEAiAZwyAz3rKwc1dq6upyBfjNG1CmLzZyMwTAsx9W65k1nBe1fI2lh7nT WWTRzZfUr19Bg54mahB4eTjZMqzdT/CohiwPehYHdPJOV1T04I2nXd0VUmn8U83TBGvm Leiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=E1wc2vADYmdO4VfcTB00D2pdpcFUyCevP9KOOTbdqQo=; b=klLXhltdC5FJUI/q1WkYYIVYa/8OQUo1wXjLg85RMpzr2wED0xgGBcgPoiedev4403 DeZjMFGdbCB5OYow4Yr80/IFs+smTkGUgvI9HEU9L6jJeDhlxwr25n5PlCEUEUC3ffVH IXqbI/KoPFq4wz4nnY2R7PA2ZDyIW4rmdw/MQg64GE1h+sMbmoDIuWeyl2treSwFAH32 9aHFpdBpQ9UFL5Qvo+FclZ9Mh4p50pS1kPEMr5CA7Mfjco7nhOn+79AwISLjE0sNtJkf Xy82fgJ1eJl/nqWKCwf7Woyy52hw22CQ9DrlZzETKSTvrHAecI3ylVLlzV/wHtRXAlb6 K4Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TP7AMNDQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si11757794eji.68.2021.06.06.21.45.12; Sun, 06 Jun 2021 21:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TP7AMNDQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbhFGEkn (ORCPT + 99 others); Mon, 7 Jun 2021 00:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbhFGEkm (ORCPT ); Mon, 7 Jun 2021 00:40:42 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB80C061766 for ; Sun, 6 Jun 2021 21:38:51 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id h8so15942666wrz.8 for ; Sun, 06 Jun 2021 21:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E1wc2vADYmdO4VfcTB00D2pdpcFUyCevP9KOOTbdqQo=; b=TP7AMNDQjPj+ycKu4IHrzlxJg0CnCoWTObFUzD4A3sdqJDkvIOxdHF98JttTRmu2i5 RcayfRsPj1AZzwg85v2M53KOpWjxLq9P77f0FTV01pybFYK5hgl2yTqSFQhSOllVYplf 5CguxbqSGEBTXJs0lpZvt48u2AmrXvWJo4QksoEwyij+Y21h2CxbJUBxaJAr9DK4iYPh 02MNHeCRaTDmLfDy61H36fGDHNO5bgY6wIE62rwTiuZIj7p3UCz0/xBWpZiVjNSlNFsd ipzgA0tJ06V/Pa6seQrX8yywdKJSf42vtzloOP/GPE5r3i/NUmMeY9YUdSlxYDCual6m GnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E1wc2vADYmdO4VfcTB00D2pdpcFUyCevP9KOOTbdqQo=; b=s4W41c3jSFm+Lqp8C0efeW254PmDj4grfo1nDxrU4G+BmT27G1Uwx+Q+mIUf/srUW3 /69Z460nJHepZhywR2gtBUHNo7ltoNl85DjC1uFlabYWwx7WH/0ZPvQVtgXtswdjK8xT X/bTEoca18Pzj6O3q9mwhvKg3nltdfLNqRUpCzpXHr+OwsOLvQnnHXzg22JcQ2fIQKLI I1jSZ+vTEnVoxfYdChv7hvoWdcR7s8uzBUDyByZsoCLEwdORtGtby7Ty3JerAWld60er gtCn1/JlNSFjO/e8umHpVuUFmcgiBhcekEkkmUyYmJzhtR0HVVA6cw24K+UIPMG9h0T8 rCHg== X-Gm-Message-State: AOAM531Guc9Ef0DU6FrDDCG99KO09k+MIY7DA/jW+rMibi47oi5F3Y4E t6sINdClmy6qQGC6OHKpmjy6AA== X-Received: by 2002:a5d:4681:: with SMTP id u1mr7857513wrq.268.1623040729275; Sun, 06 Jun 2021 21:38:49 -0700 (PDT) Received: from Iliass-MBP (ppp-94-66-57-185.home.otenet.gr. [94.66.57.185]) by smtp.gmail.com with ESMTPSA id u2sm14299429wrn.38.2021.06.06.21.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jun 2021 21:38:48 -0700 (PDT) Date: Mon, 7 Jun 2021 07:38:43 +0300 From: Ilias Apalodimas To: Tariq Toukan Cc: Matteo Croce , David Ahern , Yunsheng Lin , netdev@vger.kernel.org, linux-mm@kvack.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Subject: Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling Message-ID: References: <20210521161527.34607-1-mcroce@linux.microsoft.com> <20210521161527.34607-4-mcroce@linux.microsoft.com> <722e5567-d8ee-228c-978e-9d5966257bb1@gmail.com> <63a4ea45-9938-3106-9eda-0f7e8fe079ce@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63a4ea45-9938-3106-9eda-0f7e8fe079ce@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tariq, > > > > > > > > Yes the comment is there to prohibit people (mlx5 only actually) to add the > > > > recycling bit on their driver. Because if they do it will *probably* work > > > > but they might get random corrupted packets which will be hard to debug. > > > > > > > > > > What's the complexity for getting it to work with split page model? > > > Since 1500 is the default MTU, requiring a page per packet means a lot > > > of wasted memory. > > > > We could create a new memory model, e.g. MEM_TYPE_PAGE_SPLIT, and > > restore the behavior present in the previous versions of this serie, > > which is, save xdp_mem_info in struct page. > > As this could slightly impact the performances, this can be added in a > > future change when the drivers which are doing it want to use this > > recycling api. > > > > page-split model doesn't only help reduce memory waste, but increase > cache-locality, especially for aggregated GRO SKBs. > > I'm looking forward to integrating the page-pool SKB recycling API into > mlx5e datapath. For this we need it to support the page-split model. > > Let's see what's missing and how we can help making this happen. Yes that's the final goal. As I said I don't think adding the page split model will fundamentally change the current patchset. So imho we should get this in first, make sure that everything is fine, and then add code for the mlx cards. Regards /Ilias