Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: urVnFkjvf/R1oE970TvZaPHftm/chj9b/EhXGbLE5aanhfrk8E6eBj3SUicETeY8GepU86H1eP
 H5Wka6DZ03V7eztF6P7PITh9sonGF6YWHtGk2/d4wZvBMKM6Ow6hy1I16M3++edWOcr1Bajkck
 yRSChsZTqzJmX/wkeh3KFGf9l9llTD9wyqpbJE7sKIYMN3NalSjw2xCcvj2Ss1U16+BPSVYQJq
 GVwzahhUkfB9Q4jPRcqfnQsZyItv9s/ANeTyYbahkVnSxf0va749IsXC1iSboPHP9ZduB9m7f5
 oO4=
IronPort-SDR: okqM6UCQRpMccJuneo+TJ5roxGQ2zyPDxUqKVRkrMGXXitNUi5khfdG90aMhfSmPQuZQdyBnfN
 LGhgYoOxLSciS+T3gRIfAiswkHLXv4S74XCtRBl31VKTCzCYiwqrZ1kkMSqVTTYoSc8RANGhe+
 rdpELsF56tnHNvMGKWcXeo+Hl75RqinOh0iKYj8XHyu3zLrgGYe8+K/lY/N1aCd7M7yVA0GiIL
 fe9DO/x5lBwz1ym8QWICSwd+viuyc2BotxM0bX70F2w5pSVYESUVM34fJOIJTKqolApI3Jd/HA
 M2R31nCs/GV0md6myiEtKLTf
IronPort-SDR: t3NsnUIGc+k2cKIG+n/RK88LiXHHrq8v9nnHxut+geflD6AlbEOIIRFzNH3Dni5h0JEfhXFkYS
 oWnLG196bvt5hHVB1DaIFwUjnUzuyl8hi8b4rtxrqumhG6oF869XmMCT+7vPRozMDu6ChMh7/a
 JVTubvtwYyZ/Ex2shQWPf2kHMI6kZ7uYKUhAxTZxM6IcTGYfLHXEpzP70MQUP5wA4hM59Jp9La
 Ho5UtZAH6kil8u574K3zsoYN39iuUiyQBed+IE+xETG7juHHQ3voECPqPMsuT+t5dm0bb/GvFw
 tc8=
WDCIronportException: Internal
From:   Avri Altman <avri.altman@wdc.com>
To:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        alim.akhtar@samsung.com, asutoshd@codeaurora.org,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <avi.shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>, cang@codeaurora.org,
        stanley.chu@mediatek.com, Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v10 07/12] scsi: ufshpb: Add hpb dev reset response
Date:   Mon,  7 Jun 2021 09:13:56 +0300
Message-Id: <20210607061401.58884-8-avri.altman@wdc.com>
In-Reply-To: <20210607061401.58884-1-avri.altman@wdc.com>
References: <20210607061401.58884-1-avri.altman@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The spec does not define what is the host's recommended response when
the device send hpb dev reset response (oper 0x2).

We will update all active hpb regions: mark them and do that on the next
read.

Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
---
 drivers/scsi/ufs/ufshpb.c | 32 +++++++++++++++++++++++++++++++-
 drivers/scsi/ufs/ufshpb.h |  1 +
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 0ef46aa71045..1a29fe491c62 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -195,7 +195,8 @@ static void ufshpb_iterate_rgn(struct ufshpb_lu *hpb, int rgn_idx, int srgn_idx,
 		}
 		spin_unlock(&rgn->rgn_lock);
 
-		if (activate) {
+		if (activate ||
+		    test_and_clear_bit(RGN_FLAG_UPDATE, &rgn->rgn_flags)) {
 			spin_lock_irqsave(&hpb->rsp_list_lock, flags);
 			ufshpb_update_active_info(hpb, rgn_idx, srgn_idx);
 			spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
@@ -1417,6 +1418,20 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb,
 		queue_work(ufshpb_wq, &hpb->map_work);
 }
 
+static void ufshpb_dev_reset_handler(struct ufshpb_lu *hpb)
+{
+	struct victim_select_info *lru_info = &hpb->lru_info;
+	struct ufshpb_region *rgn;
+	unsigned long flags;
+
+	spin_lock_irqsave(&hpb->rgn_state_lock, flags);
+
+	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn)
+		set_bit(RGN_FLAG_UPDATE, &rgn->rgn_flags);
+
+	spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
+}
+
 /*
  * This function will parse recommended active subregion information in sense
  * data field of response UPIU with SAM_STAT_GOOD state.
@@ -1491,6 +1506,18 @@ void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 	case HPB_RSP_DEV_RESET:
 		dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
 			 "UFS device lost HPB information during PM.\n");
+
+		if (hpb->is_hcm) {
+			struct scsi_device *sdev;
+
+			__shost_for_each_device(sdev, hba->host) {
+				struct ufshpb_lu *h = sdev->hostdata;
+
+				if (h)
+					ufshpb_dev_reset_handler(h);
+			}
+		}
+
 		break;
 	default:
 		dev_notice(&hpb->sdev_ufs_lu->sdev_dev,
@@ -1816,6 +1843,8 @@ static int ufshpb_alloc_region_tbl(struct ufs_hba *hba, struct ufshpb_lu *hpb)
 		} else {
 			rgn->rgn_state = HPB_RGN_INACTIVE;
 		}
+
+		rgn->rgn_flags = 0;
 	}
 
 	return 0;
@@ -2141,6 +2170,7 @@ static void ufshpb_cancel_jobs(struct ufshpb_lu *hpb)
 {
 	if (hpb->is_hcm)
 		cancel_work_sync(&hpb->ufshpb_normalization_work);
+
 	cancel_work_sync(&hpb->map_work);
 }
 
diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
index 1ea58c17a4de..b863540e28d6 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -127,6 +127,7 @@ struct ufshpb_region {
 	struct list_head list_lru_rgn;
 	unsigned long rgn_flags;
 #define RGN_FLAG_DIRTY 0
+#define RGN_FLAG_UPDATE 1
 
 	/* region reads - for host mode */
 	spinlock_t rgn_lock;
-- 
2.25.1