Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210605121838.8357-1-bernard@vivo.com>
In-Reply-To: <20210605121838.8357-1-bernard@vivo.com>
From:   Christian Gmeiner <christian.gmeiner@gmail.com>
Date:   Mon, 7 Jun 2021 08:59:25 +0200
Message-ID: <CAH9NwWdKvX3SN=StUMRcmavvOwoMotjkiVzrWxrJutGEe+Ha2w@mail.gmail.com>
Subject: Re: [PATCH] drm/etnaviv: remove NULL check which is not needed
To:     Bernard Zhao <bernard@vivo.com>
Cc:     Lucas Stach <l.stach@pengutronix.de>,
        Russell King <linux+etnaviv@armlinux.org.uk>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        The etnaviv authors <etnaviv@lists.freedesktop.org>,
        DRI mailing list <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Am Sa., 5. Juni 2021 um 14:18 Uhr schrieb Bernard Zhao <bernard@vivo.com>:
>
> NULL check before kvfree functions is not needed.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index b390dd4d60b7..d741b1d735f7 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -80,8 +80,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)
>         /* Don't drop the pages for imported dmabuf, as they are not
>          * ours, just free the array we allocated:
>          */
> -       if (etnaviv_obj->pages)
> -               kvfree(etnaviv_obj->pages);
> +       kvfree(etnaviv_obj->pages);
>
>         drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt);
>  }
> --
> 2.31.0
>

Thanks for the patch, but there is an other one queued up in
etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=7d614ab2f20503ed8766363d41f8607337571adf

-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy