Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210605122415.8621-1-bernard@vivo.com>
In-Reply-To: <20210605122415.8621-1-bernard@vivo.com>
From:   Christian Gmeiner <christian.gmeiner@gmail.com>
Date:   Mon, 7 Jun 2021 08:57:37 +0200
Message-ID: <CAH9NwWcTDV70Nb_e_rs9egsQqmAo91_HM+DoO_woC_ZqnHCVNw@mail.gmail.com>
Subject: Re: [PATCH] drm/etnaviv: remove no need NULL check
To:     Bernard Zhao <bernard@vivo.com>
Cc:     Lucas Stach <l.stach@pengutronix.de>,
        Russell King <linux+etnaviv@armlinux.org.uk>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        The etnaviv authors <etnaviv@lists.freedesktop.org>,
        DRI mailing list <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Am Sa., 5. Juni 2021 um 14:24 Uhr schrieb Bernard Zhao <bernard@vivo.com>:
>
> NULL check before kvfree functions is not needed.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index d05c35994579..bd0d66ebf314 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
>  err_submit_cmds:
>         if (ret && (out_fence_fd >= 0))
>                 put_unused_fd(out_fence_fd);
> -       if (stream)
> -               kvfree(stream);
> -       if (bos)
> -               kvfree(bos);
> -       if (relocs)
> -               kvfree(relocs);
> -       if (pmrs)
> -               kvfree(pmrs);
> +       kvfree(stream);
> +       kvfree(bos);
> +       kvfree(relocs);
> +       kvfree(pmrs);
>
>         return ret;
>  }
> --
> 2.31.0
>

Thanks for the patch, but there is an other one queued up in
etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=bdf622e0fade2cec72c948c708763378b656c01d

-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy